New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691017 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: ----



Sign in to add a comment

Cannot run real hwtest for guado_moblab trybot

Project Member Reported by xixuan@chromium.org, Feb 10 2017

Issue description

When running trybot for guado_moblab, like https://uberchromegw.corp.google.com/i/chromiumos.tryserver/builders/paladin/builds/2179,

the hwtest doesn't run Moblab_Runsuite like moblab CQ (like https://uberchromegw.corp.google.com/i/chromeos/builders/guado_moblab-paladin/builds/4998), but run bvt-inline suite, which makes no real tests are run due to "TEST_NA: Skipping:  test not supported on this board/pool.".

@don / @nxia Any idea about this?

 

Comment 1 by nxia@chromium.org, Feb 10 2017

https://cs.corp.google.com/chromeos_public/chromite/lib/config_lib.py?type=cs&q=OverrideConfigForTrybot&sq=package:%5Echromeos_(internal%7Cpublic)$&l=194

if it's a tryjob and hw_tests_override is not null, hw_tests will be overwritten by hw_tests_overriden 
Owner: dgarr...@chromium.org
Status: Started (was: Untriaged)
That's exactly what's happening. This looks like a bug in that build config though.
This is the quick fix:

https://chromium-review.googlesource.com/c/440436/

If I have time, I'll do a better cleanup to avoid this kind of error in the future.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 11 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/00f07b89e20a186fffe819c5f6b8d75971ba3cf6

commit 00f07b89e20a186fffe819c5f6b8d75971ba3cf6
Author: Don Garrett <dgarrett@google.com>
Date: Sat Feb 11 08:35:24 2017

chromeos_config: Fix broken hwtest_overrides.

We were setting custom hwtests for some boards, then letting the
override go back to standard behavior, which meant that tryjobs didn't
run the expected hwtests.

BUG= chromium:691017 
TEST=cbuildbot/chromeos_config_unittests

Change-Id: I76630375d854257ad61a6c9a7a42a246fdd55f3c
Reviewed-on: https://chromium-review.googlesource.com/440436
Commit-Ready: Don Garrett <dgarrett@chromium.org>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Ningning Xia <nxia@chromium.org>

[modify] https://crrev.com/00f07b89e20a186fffe819c5f6b8d75971ba3cf6/cbuildbot/config_dump.json
[modify] https://crrev.com/00f07b89e20a186fffe819c5f6b8d75971ba3cf6/cbuildbot/chromeos_config.py

Components: -Infra Infra>Client>ChromeOS
Status: Fixed (was: Started)
Should be fixed. Can you confirm?

Comment 7 by xixuan@chromium.org, Feb 13 2017

Status: Verified (was: Fixed)

Sign in to add a comment