New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 691013 link

Starred by 1 user
Status: Fixed
Owner:
dcasta...@chromium.org
Closed: Feb 2017
Cc:
█ reve...@chromium.org
diand...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Pepper plugin content is flipped when it gets promoted to an overlay.

Project Member Reported by dcasta...@chromium.org, Feb 10 2017 
Chrome Version: CrOS 58 (Need to check on previous ones)
This happens on kevin, and I suspect it's happening on minnie to.

What steps will reproduce the problem?
(1) Go to any page with flash/pepper content that can be maximized to full screen (e.g: http://permadi.com/tutorial/flash9FullScreen/index.html)
(2) Toggle Full screen
(3) Wait for any element on top to disappear (pop up saying to press esc), and for the content to be promoted to an overlay.


What is the expected result?

Content not flipped

What happens instead?

The content will be scaled by -1,-1

Please use labels and text to provide additional information.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/15d052adb744d524228947248ab96c80b3bdf7ad

commit 15d052adb744d524228947248ab96c80b3bdf7ad
Author: dcastagna <dcastagna@chromium.org>
Date: Fri Feb 17 21:04:35 2017

cc: Make SingleOnTop strategy reject transformed overlays.

Currently overlay transforms are ignored by ozone drm platform.
This is causing pepper content to be displayed upside down on certain
devices.

This CL always rejects overlays in SingleOnTop strategy with transform
different than identity while we work on supporting the rotation
(that can be also used for mirroring) property.

Currently OverlayStrategySingleOnTop is used only on drm platforms.

BUG= 691013 
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2698843005
Cr-Commit-Position: refs/heads/master@{#451378}

[modify] https://crrev.com/15d052adb744d524228947248ab96c80b3bdf7ad/cc/output/overlay_strategy_single_on_top.cc
[modify] https://crrev.com/15d052adb744d524228947248ab96c80b3bdf7ad/cc/output/overlay_unittest.cc

Comment 2 by dcasta...@chromium.org, Feb 17 2017

Status: Fixed (was: Assigned)

Comment 3 by diand...@chromium.org, Feb 17 2017 

Should we request merge to M-57?

Comment 4 by dcasta...@chromium.org, Feb 17 2017 

@dianders: M-57 shouldn't be affected by this. The fullscreen strategy, that is the only one enabled on 57, already rejects overlays with non identity transforms.

Comment 5 by diand...@chromium.org, Feb 17 2017

Labels: M-58
Yay!

Comment 6 by dcasta...@chromium.org, Apr 5 2017 

 Issue 691014  has been merged into this issue.
►

Sign in to add a comment