New issue
Advanced search Search tips

Issue 691010 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 672152



Sign in to add a comment

Verify arguments for should()

Project Member Reported by hongchan@chromium.org, Feb 10 2017

Issue description

should() needs to check if it is getting proper arguments. No argument MUST throw.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4588d6d0889bd6cfc9c50dd1af6b5d206a55d366

commit 4588d6d0889bd6cfc9c50dd1af6b5d206a55d366
Author: hongchan <hongchan@chromium.org>
Date: Tue Feb 14 20:20:51 2017

Fix should() to throw with no argument

should() needs to check if it is getting proper arguments. No argument
MUST throw.

BUG= 691010 
TEST=
LayoutTests/webaudio/unit-tests/audit.html

Review-Url: https://codereview.chromium.org/2693043005
Cr-Commit-Position: refs/heads/master@{#450443}

[modify] https://crrev.com/4588d6d0889bd6cfc9c50dd1af6b5d206a55d366/third_party/WebKit/LayoutTests/webaudio/resources/audit.js
[modify] https://crrev.com/4588d6d0889bd6cfc9c50dd1af6b5d206a55d366/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit-expected.txt
[modify] https://crrev.com/4588d6d0889bd6cfc9c50dd1af6b5d206a55d366/third_party/WebKit/LayoutTests/webaudio/unit-tests/audit.html

Status: Verified (was: Started)

Sign in to add a comment