New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 691008 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Email to this user bounced
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 678905



Sign in to add a comment

Update service worker URL resolution to latest settings object changes

Project Member Reported by domenic@chromium.org, Feb 10 2017

Issue description

In https://github.com/w3c/ServiceWorker/issues/922 and follow-up PRs https://github.com/w3c/ServiceWorker/pull/950 and https://github.com/w3c/ServiceWorker/pull/963 we updated the service worker spec to follow the prevailing advice and use the current and relevant settings objects instead of the entry and incumbent settings objects.

Web platform tests are available for this change at https://github.com/w3c/web-platform-tests/pull/3449 with the relevant test being at  service-workers/service-worker/multi-globals/url-parsing.https.html ; this should be imported shortly via the automatic WPT import process. Chrome currently fails all of them; Gecko passes 2/3.
 

Comment 1 by falken@chromium.org, Feb 13 2017

Blocking: 678905
Cc: -falken@chromium.org
Owner: falken@chromium.org
Status: Assigned (was: Untriaged)
I found that I missed a thing during the review of the WPT test for this. The fetch('relevant/test.txt') called from the url-parsing.html can't be intercepted as the client itself is out-of-scope to relevent/test-sw.js. I'll try to fix that.

Also if you didn't start this issue and don't mind, I can work on this while fixing the test. Let me know.
FYI: WPT has been imported at https://codereview.chromium.org/2697453005/.

Comment 5 by falken@chromium.org, Feb 14 2017

Cc: falken@chromium.org
Owner: jungkee....@samsung.com
Jungkee: Sure, it would be great if you can fix this.
Sure, I'll take this. Thanks.

Comment 7 by jochen@chromium.org, Feb 24 2017

 Issue 695831  has been merged into this issue.
Project Member

Comment 8 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/255f7943ef67812af69da392fc5f62cb6f74cf96

commit 255f7943ef67812af69da392fc5f62cb6f74cf96
Author: jungkee.song <jungkee.song@samsung.com>
Date: Sat Feb 25 01:00:33 2017

ServiceWorker: Change base URL for parsing script URL and scope URL

According to the spec change, this changes to use the relevant settings object
instead of the entry settings object to parse the script URL and the scope URL
given to ServiceWorkerContainer.register() and
ServiceWorkerContainer.getRegistration().

Before this CL, register() and getRegistration() used entered execution context
to parse the URLs. After this CL, the methods use the execution context
retrieved from ScriptState::getExecutionContext().

WPT: external/wpt/service-workers/service-worker/multi-globals/url-parsing.https.html

Spec issue: https://github.com/w3c/ServiceWorker/issues/922
Spec change: https://github.com/w3c/ServiceWorker/commit/ec1aac220646a5ea15583e22da1373581a8f2f23

BUG= 691008 

Review-Url: https://codereview.chromium.org/2691903005
Cr-Commit-Position: refs/heads/master@{#453033}

[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/f40832ec30f1e19f28ca4dfab9e24d608fcefa28/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/controller-on-load.https-expected.txt
[delete] https://crrev.com/f40832ec30f1e19f28ca4dfab9e24d608fcefa28/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/controller-on-reload.https-expected.txt
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/controller-on-reload.https.html
[delete] https://crrev.com/f40832ec30f1e19f28ca4dfab9e24d608fcefa28/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/multi-globals/url-parsing.https-expected.txt
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/multiple-register.https.html
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/LayoutTests/external/wpt/service-workers/service-worker/registration-iframe.https.html
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/LayoutTests/http/tests/background_sync/oneshot.html
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/LayoutTests/http/tests/serviceworker/controller-on-reload.html
[delete] https://crrev.com/f40832ec30f1e19f28ca4dfab9e24d608fcefa28/third_party/WebKit/LayoutTests/http/tests/serviceworker/registration-iframe.html
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/Source/bindings/core/v8/V8Binding.h
[modify] https://crrev.com/255f7943ef67812af69da392fc5f62cb6f74cf96/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Comment 9 by falken@chromium.org, Mar 29 2017

Labels: M-58
Status: Fixed (was: Assigned)
Fixed in M58.

Sign in to add a comment