New issue
Advanced search Search tips

Issue 690992 link

Starred by 2 users
Status: Assigned
Owner:
manucornet@chromium.org
Cc:
fukino@chromium.org
yamaguchi@chromium.org
tetsui@chromium.org
zork@chromium.org
est...@chromium.org
manucornet@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocked on:
issue 686234
issue 686245
issue 686286
issue 686296
issue 687800
issue 687803
issue 687806
issue 687812


Sign in to add a comment

Consider refactoring opportunities in ash::TrayBackgroundView and its subclasses

Project Member Reported by tdander...@chromium.org, Feb 10 2017 
Consider further refactoring opportunities in TrayBackgroundView and its subclasses once all of the non-MD code has been removed.

Comment 1 by moh...@chromium.org, Feb 22 2017 

Both VirtualKeyboardTray and OverviewButtonTray have an identical SetIconBorderForShelfAlignment() which can be a good candidate for refactoring and code sharing. (Probably, other "square" buttons on shelf have similar code, too.)

Comment 2 by tdander...@chromium.org, Apr 10 2017

Labels: -M-59

Comment 3 by tdander...@chromium.org, Aug 9 2017

Cc: tbuck...@chromium.org zork@chromium.org fukino@chromium.org
Owner: jamescook@chromium.org
Status: Untriaged (was: Assigned)
James, do you mind assisting with the re-triage of this ash/system code health bug?

tbuckley@, zork@, fukino@: FYI in case you know of a good owner.

Comment 4 by jamescook@chromium.org, Aug 10 2017

Status: Assigned (was: Untriaged)

Comment 5 by vadimt@chromium.org, Nov 29 2017

Labels: Not-Touch-Friendly-Launcher

Comment 6 by jamescook@chromium.org, Aug 10

Owner: satorux@chromium.org
Summary: Consider refactoring opportunities in ash::TrayBackgroundView and its subclasses (was: Consider refactoring opportunities in TrayBackgroundView and its subclasses)
Satoru, does your team have any plans for status area cleanup after the launch of unified system tray? This would be nice to look at.

Comment 7 by satorux@chromium.org, Aug 13

Owner: tetsui@chromium.org
tetsui@, could you take a look once the unified system tray is done?

Comment 8 by tetsui@chromium.org, Aug 13

Cc: -moh...@chromium.org -bruthig@chromium.org -tbuck...@chromium.org -yiyix@chromium.org yamaguchi@chromium.org manucornet@chromium.org
sure.

Comment 9 by tetsui@chromium.org, Oct 10

Cc: tetsui@chromium.org
Owner: manucornet@chromium.org
Reassigning to manucornet@ who owns StatusArea.

Comment 10 by manucornet@chromium.org, Dec 29

Components: -UI>Shell>Shelf UI>Shell>StatusArea
►

Sign in to add a comment