GalleryBrowserTest.RotateImageOnDrive flaking on Linux ChromiumOS Tests (dbg) |
||||||||||
Issue descriptionChrome Version: 58.0.3007.0 The GalleryBrowserTest.RotateImageOnDrive test is flaking frequently on the Linux ChromiumOS Tests (dbg) builder (https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29). The flakes are causing the builder to fail roughly 1 in 10 times. The most recent failure was in https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/22344 I saved the test log to https://paste.googleplex.com/4653886790959104, but I'm not sure how much use it will be. All four stack traces look rather different. Flakes go back over a week, and there are no recent changes in gallery_browsertest.cc, file_manager_browsertest_base.cc, or ui/file_manager/integration_tests/gallery/photo_editor.js, so I have no suspects for a CL to blame. +yawano@, as the most frequent contributor to gallery_browsertest.cc, do you have any idea what might be causing this, or know where to triage it to?
,
Feb 13 2017
yamaguchi@, could you look into this?
,
Feb 14 2017
,
Feb 14 2017
[9642:9642:0210/072050.346371:INFO:CONSOLE(112)] "Slide mode state, expected is {"width":800,"height":600,"name":"My Desktop Background"}, actual is {"width":800,"height":600,"name":""}.", source:
It indicates that the value of the <input> element (which shows the filename of the image being edited, shown on the top-left of the view) was empty.
This is likely to be output at this line:
A] setupPhotoEditor() https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/gallery/photo_editor.js?q=rotateImageOnDrive&sq=package:chromium&l=27
A strange point which I still don't understand is that it should retry even when seeing the unexpected status of the elements, but it crashed by a signal right after getting the unexpected status according to the log.
- https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/test_util.js?l=106&q=repeatUntil
Another possible line which can output the same log would be
B] after showing the image correctly with the filename and then rotating the image https://cs.chromium.org/chromium/src/ui/file_manager/integration_tests/gallery/photo_editor.js?q=rotateImageOnDrive&sq=package:chromium&l=69
However it won't happen unless the input field is erased right after rotating the image, but I could not see that happens in normal operation. (Though it can happen when the selection is cleared, it will only happen when deleting the image file.)
,
Feb 14 2017
#4 might not be related to this issue. As noted in the description, existing logs indicate that the test is crashing asynchronously with the execution of the js test code. I am running the test in the local environment repeatedly, but haven't got the error reproduced.
,
Feb 14 2017
Thank you for investigating. But let me disable the test to keep the tree green. https://codereview.chromium.org/2695803005/
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/184b4198c0bdee9dfbb146b26796945916419dbe commit 184b4198c0bdee9dfbb146b26796945916419dbe Author: tyoshino <tyoshino@chromium.org> Date: Tue Feb 14 09:28:53 2017 Disable GalleryBrowserTest.RotateImageOnDrive for Chrome OS debug build BUG= 690983 TBR=yamaguchi@chromium.org Review-Url: https://codereview.chromium.org/2695803005 Cr-Commit-Position: refs/heads/master@{#450304} [modify] https://crrev.com/184b4198c0bdee9dfbb146b26796945916419dbe/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
Feb 15 2017
Confirmed that it's SKIP-ed now. Removing Hotlist-Sheriff-Chromium label.
,
Mar 1 2017
Please use Sheriff-Chromium label instead of Hotlist-Sheriff-Chromium. Issues with Sheriff-Chromium label are shown in Sheriff-o-Matic and are tried by sheriffs directly.
,
Mar 1 2017
Turns out search on Monorail is eventually consistent. Removing Sheriff-Chromium from this issue since Hotlist-Sheriff-Chromium was removed earlier.
,
Mar 10 2017
,
Apr 24 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/124238f4424a05e57558c0f309ac011e4fe0b76a commit 124238f4424a05e57558c0f309ac011e4fe0b76a Author: Noel Gordon <noel@chromium.org> Date: Tue Apr 24 12:53:06 2018 Re-enable GalleryBrowserTest.RotateImageOnDrive in DEBUG Fixed on issue 831074 issue 804413 issue 829310 . Tbr: yamaguchi-san Bug: 835794 , 690983 Change-Id: Ia92b6e5a096760c747ebb20802dc59f07f918ea5 Reviewed-on: https://chromium-review.googlesource.com/1025850 Reviewed-by: Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#553063} [modify] https://crrev.com/124238f4424a05e57558c0f309ac011e4fe0b76a/chrome/browser/chromeos/file_manager/gallery_browsertest.cc
,
Apr 24 2018
,
Jun 28 2018
I think this has been fixed.
,
Jun 28 2018
yamaguchi@ thanks and agree, it has been fixed [1] [1] https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=GalleryBrowserTest.RotateImageOnDrive |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by tyoshino@chromium.org
, Feb 13 2017Owner: fukino@chromium.org
Status: Assigned (was: Untriaged)