New issue
Advanced search Search tips

Issue 690972 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug-Regression



Sign in to add a comment

[clang] CLANG_REVISION = '289944' crashes compiling chrome_content_client.cc

Reported by cmsigler...@gmail.com, Feb 10 2017

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/56.0.2924.87 Safari/537.36

Steps to reproduce the problem:
1. Prepare to build chromium on Linux (my system is x86_64 4.9.8-1-ARCH) with gcc ver. >=6.2.1 stack installed
2. Build project using bundled clang binary CLANG_REVISION = '289944'
3. Build dies compiling chrome_content_client.cc

What is the expected behavior?
Project builds without error.

What went wrong?
clang crashes compiling chrome_content_client.cc due to bug in clang itself.

Did this work before? Yes 56.0.2897.0

Chrome version: 58.0.3004.3  Channel: dev
OS Version: 4.9.8-1-ARCH
Flash Version: Shockwave Flash 23.0 r0

PLEASE SEE llvm.org/bugs/show_bug.cgi?id=31043 -- llvm  Bug 31043 .
I am running Arch Linux x86_64 4.9.8-1-ARCH w/gcc ver. 6.3.1 stack installed.
The reported llvm bug identifies this crash with chromium 56.0.2914.3 with gcc ver. 6.2.1 installed.

HTH.

Clemmitt Sigler

 
I should have added that llvm  Bug 31043  shows this clang bug was fixed in r291064 of llvm.

Clemmitt Sigler

Components: -Platform>DevTools Build
Update:  I missed this bug comment when researching for duplicates:

https://bugs.chromium.org/p/chromium/issues/detail?id=685244#c9

 Issue 685244  "roll clang again" will fix this bug.  HTH.

Clemmitt Sigler

Cc: rbasuvula@chromium.org
Labels: TE-NeedsTriageHelp
This looks like out of scope for TE, hence adding the respective label for it to  triage further.
Tracking -- clang rolled from r289944 to r295762 -- see the following:

https://bugs.chromium.org/p/chromium/issues/detail?id=685244#c29
https://chromium.googlesource.com/chromium/src/+/c702a811babe12110a84d644ee81b6d99b2f4716

Nocompile tests disabled after clang roll as results need rebasing:

https://bugs.chromium.org/p/chromium/issues/detail?id=695991
https://bugs.chromium.org/p/chromium/issues/detail?id=685244#c30
https://chromium.googlesource.com/chromium/src.git/+/b87e5b0b9505543cc4270479af08e60da11cd507

So far clang roll is in force and hasn't been reverted (fingers crossed any further problems are easily fixed).

As the reported clang crash was fixed in llvm/clang r291064, rolling to r295762 is expected to fix this.  I'll close this when fix is verified.

Clemmitt Sigler

Tracking -- Failure of nocompile test due to clang roll fixed -- see the following:

https://bugs.chromium.org/p/chromium/issues/detail?id=681136#c38
https://chromium.googlesource.com/chromium/src.git/+/7525a848b3036662353f3d3b244fa4e3e9114f9e

Seems clang roll from r289944 to r295762 won't be reverted :)

Still waiting for chromium-source-tarball dev channel update for desktop to verify fix compiling with clang under Linux.

Clemmitt Sigler

Tracking -- clang rolled again due to another compiler/code regression -- see:

https://bugs.chromium.org/p/chromium/issues/detail?id=685244#c31
https://bugs.chromium.org/p/chromium/issues/detail?id=696607

Note that the corresponding llvm/clang bugzilla says, "The problem with the inlined inheriting constructor should be fixed by CFE r296388."  This re-roll advances to revision 296320, but not >= revision 296388.  See:

https://bugs.llvm.org/show_bug.cgi?id=32042#c11

Clemmitt Sigler

Tracking -- looks like this is settling down now -- see:

https://bugs.chromium.org/p/chromium/issues/detail?id=696607#c2

Again, will report results of testing when possible, expecting this bug to be fixed.

Clemmitt Sigler

Hi,

Can I close my own bug?  I can't see how to do that.  This one should be closed now as clang has rolled past the compiler error which this bug reports.

If someone has permission to change status please mark this one Fixed.  TIA.

Clemmitt Sigler

Hi,

I can confirm this bug should be CLOSED/FIXED.  Tree builds again under Linux x86_64 as of Dev Channel update for desktop release 58.0.3029.6

Please close this bug as FIXED.  TIA.

Clemmitt Sigler

Comment 11 by h...@chromium.org, Jun 19 2017

Status: Fixed (was: Unconfirmed)
Components: Tests>Disabled
Labels: Test-Disabled

Sign in to add a comment