New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690960 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Feature

Blocking:
issue 695103
issue 695462



Sign in to add a comment

Provide an WebContents API exposing if a video is effectively fullscreen

Project Member Reported by mlamouri@chromium.org, Feb 10 2017

Issue description

With the new concept of "dominant" video in HTMLMediaElement/WebMediaPlayer, we could merge it with a fullscreen video to allow content/ embedders to have behaviour based on whether a video is currently fullscreen (or almost fullscreen in the case of dominant).
 
Blocking: 679364
Cc: dalecur...@chromium.org zqzh...@chromium.org m...@chromium.org
CC'ing some people that might be interested.

FWIW, I not 100% clear what information we could provide. I'w considering starting with only exposing a "playing fullscreen/dominant" API then maybe add something were it's possible to get status information about a dominant video.
Cc: liber...@chromium.org
Summary: Provide an WebContents API exposing if a video is effectively fullscreen (was: Provide an WebContents API exposing if a video is fullscreen or dominant)
Blocking: 695103
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e52c1b5442d81049d4b47b716d994ba746dde8a3

commit e52c1b5442d81049d4b47b716d994ba746dde8a3
Author: mlamouri <mlamouri@chromium.org>
Date: Thu Feb 23 14:57:50 2017

Provide a WebContents API to discover the playback of a fullscreen video.

That means a video is playing fullscreen, either directly (native controls) or
indirectly (custom controls). This is only exposed to the Java WebContents API
at the moment.

BUG= 690960 

Review-Url: https://codereview.chromium.org/2693203002
Cr-Commit-Position: refs/heads/master@{#452487}

[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/browser/media/media_web_contents_observer.h
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/browser/web_contents/web_contents_android.cc
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/browser/web_contents/web_contents_android.h
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/common/media/media_player_delegate_messages.h
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/public/android/java/src/org/chromium/content_public/browser/WebContents.java
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/renderer/media/renderer_webmediaplayer_delegate.cc
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/renderer/media/renderer_webmediaplayer_delegate.h
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/content/renderer/media/webmediaplayer_ms_unittest.cc
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/media/blink/webmediaplayer_delegate.h
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/media/blink/webmediaplayer_impl.cc
[modify] https://crrev.com/e52c1b5442d81049d4b47b716d994ba746dde8a3/media/blink/webmediaplayer_impl_unittest.cc

Status: Fixed (was: Started)
Blocking: 695462

Comment 9 by dah...@chromium.org, Mar 29 2017

Blocking: -679364

Sign in to add a comment