CQ messages should be tagged as automated so that “Show comments only” works properly |
|||
Issue descriptionConsider my recent CL here: https://chromium-review.googlesource.com/c/439326/ I submit almost every patchset for CQ dry-run, because what's the point of a patchset that doesn't compile/pass tests. But, this means that any actual code review gets completely lost in the noise of "Commit Queue +1", "CQ is trying da patch", wtc.. Showing comments only doesn't help. It'd be great to be able to hide everything except actual useful code comments (and maybe CQ failures).
,
Feb 13 2017
I already set the tag as "cq" and can change it to anything else necessary. Let me know what else I should do and I'd deploy it within a day!
,
Feb 13 2017
We treat any tag that has the string 'autogenerated' as the first part of the tag as an automated message. The convention that we are trying to follow is the tag will be formatted like: autogenerated:<source>:<description> For example, the tag for a Gerrit API that deletes an assignee is "autogenerated:gerrit:deleteAssignee" Hope this helps! Becky
,
Feb 13 2017
Thanks, that's exactly what I needed. CL: https://chrome-internal-review.googlesource.com/327523
,
Feb 13 2017
The following revision refers to this bug: https://chrome-internal.googlesource.com/infra/infra_internal/+/4eb813013beb05ce77ee867aa6c3787fff9d4c0f commit 4eb813013beb05ce77ee867aa6c3787fff9d4c0f Author: Andrii Shyshkalov <tandrii@chromium.org> Date: Mon Feb 13 21:37:11 2017
,
Feb 13 2017
Verified on https://chromium-review.googlesource.com/c/442124/: first dry run was before, second dry run was after and CQ messages are now properly filtered out. |
|||
►
Sign in to add a comment |
|||
Comment 1 by andyb...@chromium.org
, Feb 13 2017Labels: Pri-2
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
Summary: CQ messages should be tagged as automated so that “Show comments only” works properly (was: CQ dry runs make reviews hard to follow)