PlzNavigate: Missing line number in console messages when the 'frame-src' CSP is infringed. |
|||||||
Issue descriptionWith PlzNavigate, after the CL https://codereview.chromium.org/2655463006/ (Not landed yet -- 02/10/2017) The console error message doesn't display the line number of the script that inserted the blocked iframe. For instance, in the test: http/tests/security/contentSecurityPolicy/1.1/child-src/frame-blocked.html - CONSOLE ERROR: line 13: Refused to frame ... + CONSOLE ERROR: Refused to frame ...
,
May 23 2017
mkwst@ Do you think this bug is blocking PlzNavigate for launch in M60? I investigated and found what the problem is. The source location is captured in LocalFrameClientImpl::DecidePolicyForNavigation([...]) https://cs.chromium.org/chromium/src/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp?type=cs&l=555 ``` std::unique_ptr<SourceLocation> source_location = SourceLocation::Capture(web_frame_->GetFrame()->GetDocument()); ``` The problem is that it is not always the frame that is navigating that has initiated the navigation. It might be its parent for instance.
,
May 24 2017
,
May 29 2017
FYI: WIP CL https://codereview.chromium.org/2901223003/
,
Jun 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661 commit ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661 Author: arthursonzogni <arthursonzogni@chromium.org> Date: Fri Jun 02 10:40:27 2017 PlzNavigate: Fix wrong SourceLocation. Before this CL, when an iframe is asked to navigate, the SourceLocation used was the wrong one. It was always the one of the current document, even when the navigation was initiated by another frame. TEST=http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html The test still does not pass however. It is due to https://crbug.com/718942 which is not related to this issue. BUG= 690946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2901223003 Cr-Commit-Position: refs/heads/master@{#476613} [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/core/frame/LocalFrameClient.h [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/core/loader/EmptyClients.cpp [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/core/loader/FrameLoader.h [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp [modify] https://crrev.com/ccfe0b5a32bc0ed36a95eb1da8e7f4b03268a661/third_party/WebKit/Source/web/LocalFrameClientImpl.h
,
Jun 2 2017
,
Jun 8 2017
,
Jun 8 2017
Your change meets the bar and is auto-approved for M60. Please go ahead and merge the CL to branch 3112 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), josafat@(ChromeOS), bustamante@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 8 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/536326a013d7b979106706b80e964dc803c160c5 commit 536326a013d7b979106706b80e964dc803c160c5 Author: John Abd-El-Malek <jam@chromium.org> Date: Thu Jun 08 17:20:06 2017 PlzNavigate: Fix wrong SourceLocation. Before this CL, when an iframe is asked to navigate, the SourceLocation used was the wrong one. It was always the one of the current document, even when the navigation was initiated by another frame. TEST=http/tests/security/contentSecurityPolicy/frame-src-cross-origin-load.html The test still does not pass however. It is due to https://crbug.com/718942 which is not related to this issue. BUG= 690946 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_browser_side_navigation_rel Review-Url: https://codereview.chromium.org/2901223003 Cr-Original-Commit-Position: refs/heads/master@{#476613} Review-Url: https://codereview.chromium.org/2924293002 . Cr-Commit-Position: refs/branch-heads/3112@{#257} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/core/frame/LocalFrameClient.h [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/core/loader/EmptyClients.cpp [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/core/loader/EmptyClients.h [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/core/loader/FrameLoader.cpp [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/core/loader/FrameLoader.h [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp [modify] https://crrev.com/536326a013d7b979106706b80e964dc803c160c5/third_party/WebKit/Source/web/LocalFrameClientImpl.h |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Mar 30 2017