New issue
Advanced search Search tips

Issue 690945 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-04-05
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Need to press the rebase button - gerrit should do it automatically! Also confusing error message...

Project Member Reported by marja@chromium.org, Feb 10 2017

Issue description

I had this CL:

https://chromium-review.googlesource.com/c/440984

The CL that this one depends on landed.

And then I tried to land this CL...

But gerrit told me:

Failed to submit 1 change due to the following problems:
Change 440984: depends on change that was not submitted

Please, unvote/vote on Commit Queue label to re-trigger on the same patchset.
Bot data: {"action": "cancel", "triggered_at": "2017-02-10T14:50:09.0Z", "revision": "914234f08e9d3506d73432426d84aa7237373d49"}

The solution was that I need to press the rebase button and then submit.

Gerrit should do that automatically instead.
 
Labels: Pri-2
Owner: tandrii@chromium.org
Status: Assigned (was: Untriaged)
To Andrii to triage.
Marja@ for some reason I can't find what https://chromium-review.googlesource.com/c/440984/ depended on (I tried checking all patchsets, but Gerrit now returns nothing :(). Can you help me?

I suspect this is this bug https://b.corp.google.com/issues/35190185 (internal). Can you check this https://b.corp.google.com/issues/35190185#comment3 and see if the events were as described there
(note: I am not asking you to agree with rational for WAI there).

Comment 3 by marja@chromium.org, Feb 13 2017

I guess it used to depend on this one: https://chromium-review.googlesource.com/c/440246/

Maybe rebasing it cleared the dependency?

(I'll check out the bug you linked later.)

Comment 4 by marja@chromium.org, Feb 14 2017

I don't think it's the same bug as https://b.corp.google.com/issues/35190185 . In that one, the user rebases A, and then B is no longer landable.

I didn't rebase A. I just landed A, and then tried to land B. Plus, in my case, rebasing B succeeded (in the other bug, it failed).
Yep, this is something else then.
Status: ExternalDependency (was: Assigned)
Igor also hit the same issue today and I've filed a bug since on his two CLs dependnecies still show: https://b.corp.google.com/issues/35377658

If Gerrit team can't resolve it short-term, I will call "rebase" in CQ whenever this exception is hit.
Cc: tandrii@chromium.org
Owner: ----
NextAction: 2017-03-15
Gerrit has done substantial work, including changes to upstream Git, but things are still not ready. 
NextAction: 2017-04-05
tandrii@: what's the status of this? Both in terms of the external dependency and the CQ-side workaround? Can/Should I bump this to -Launch, or do we expect it to be resolved by the time dogfood emails go out?
Cc: -tandrii@chromium.org aga...@chromium.org
Owner: tandrii@chromium.org
Status: Fixed (was: ExternalDependency)
The linked bug above is marked as fixed. I've also filed a potential CL (cl/151749669) which may help avoid some user confusion when a change needs to be rebased. Marking this as fixed based on state of internal tracking bug.

Sign in to add a comment