New issue
Advanced search Search tips

Issue 690937 link

Starred by 2 users
Status: Fixed
Owner:
a...@chromium.org
Closed: May 2017
Cc:
a...@chromium.org
sdefresne@chromium.org
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

base::SupportsUserData API should use std::unique_ptr<>

Project Member Reported by sdefresne@chromium.org, Feb 10 2017 
base::SupportsUserData owns the base::SupportsUserData::Data objects passed to SetUserData() but does not enforce this. This is documented in the method comment, but could be enforced by changing the method to take the parameter as a std::unique_ptr<>.

This would make the API safer (as there won't be a risk of double-delete of the Data object).
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae5e2d28e5254462e5e5d973b788a574b3053b8f

commit ae5e2d28e5254462e5e5d973b788a574b3053b8f
Author: sdefresne <sdefresne@chromium.org>
Date: Mon Feb 13 11:49:26 2017

Update SupportsUserData API to accept std::unique_ptr<>.

SupportsUserData takes ownership of the SupportsUserData::Data
passed to SetUserData. Add an overload taking a std::unique_ptr
so that client code can be converted incrementally.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2680403004
Cr-Commit-Position: refs/heads/master@{#449933}

[modify] https://crrev.com/ae5e2d28e5254462e5e5d973b788a574b3053b8f/base/supports_user_data.cc
[modify] https://crrev.com/ae5e2d28e5254462e5e5d973b788a574b3053b8f/base/supports_user_data.h
[modify] https://crrev.com/ae5e2d28e5254462e5e5d973b788a574b3053b8f/base/supports_user_data_unittest.cc

Comment 2 by a...@chromium.org, Apr 13 2017

Cc: a...@chromium.org
 Issue 682506  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1ed4a43703873eced52dae51c62682fef5cfd9b7

commit 1ed4a43703873eced52dae51c62682fef5cfd9b7
Author: avi <avi@chromium.org>
Date: Tue Apr 25 05:39:41 2017

Switch to using scoped_ptr with UserData

BUG= 690937 
TEST=none

Review-Url: https://codereview.chromium.org/2815913005
Cr-Commit-Position: refs/heads/master@{#466896}

[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/chrome/browser/browsing_data/browsing_data_remover_impl_unittest.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/chrome/browser/ui/webui/settings/downloads_handler_unittest.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/components/data_use_measurement/core/data_use_user_data.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/components/data_use_measurement/core/data_use_user_data.h
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/components/domain_reliability/uploader.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/appcache/appcache_host.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/appcache/appcache_host.h
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/appcache/appcache_interceptor.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/appcache/appcache_interceptor.h
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/appcache/appcache_request_handler_unittest.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/background_fetch/background_fetch_test_base.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/browser_context.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/download/download_request_core.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/loader/resource_request_info_impl.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/loader/resource_scheduler.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/resource_context_impl.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/service_worker/foreign_fetch_request_handler.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/service_worker/service_worker_response_info.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/ssl/ssl_manager.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/streams/stream_context.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/websockets/websocket_handshake_request_info_impl.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/websockets/websocket_handshake_request_info_impl.h
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/browser/webui/url_data_manager.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/common/net/url_fetcher.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/content/public/browser/browser_context.h
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/google_apis/gaia/gaia_auth_util.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/net/url_request/report_sender.cc
[modify] https://crrev.com/1ed4a43703873eced52dae51c62682fef5cfd9b7/net/url_request/url_fetcher.h
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f

commit 3ed8a8e75b505e27b8498ab83e82dffb7e50c83f
Author: avi <avi@chromium.org>
Date: Fri Apr 28 15:27:17 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2847763003
Cr-Commit-Position: refs/heads/master@{#468004}

[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/content/browser/content_autofill_driver_factory.cc
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/core/browser/webdata/autocomplete_sync_bridge.cc
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/core/browser/webdata/autocomplete_syncable_service.cc
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/core/browser/webdata/autofill_profile_syncable_service.cc
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/core/browser/webdata/autofill_wallet_metadata_syncable_service.cc
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/core/browser/webdata/autofill_wallet_syncable_service.cc
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/ios/browser/autofill_driver_ios.h
[modify] https://crrev.com/3ed8a8e75b505e27b8498ab83e82dffb7e50c83f/components/autofill/ios/browser/autofill_driver_ios.mm
Project Member

Comment 7 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9ba67a80e774e24203bde94cb41add81567af4b

commit d9ba67a80e774e24203bde94cb41add81567af4b
Author: avi <avi@chromium.org>
Date: Fri Apr 28 15:27:57 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2844413004
Cr-Commit-Position: refs/heads/master@{#468005}

[modify] https://crrev.com/d9ba67a80e774e24203bde94cb41add81567af4b/chromecast/browser/android/cast_web_contents_activity.cc
[modify] https://crrev.com/d9ba67a80e774e24203bde94cb41add81567af4b/chromecast/browser/android/cast_web_contents_activity.h
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37c9356daeb495268f0ccc950c2c8095c0edd0e9

commit 37c9356daeb495268f0ccc950c2c8095c0edd0e9
Author: avi <avi@chromium.org>
Date: Fri Apr 28 15:33:30 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2853443002
Cr-Commit-Position: refs/heads/master@{#468008}

[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/find_in_page/find_tab_helper.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/find_in_page/find_tab_helper.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/infobars/infobar_manager_impl.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/ssl/captive_portal_detector_tab_helper.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/tabs/tab_model_list.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/ui/dialogs/javascript_dialog_blocking_util.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/web/dom_altering_lock.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/web/network_activity_indicator_tab_helper.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/web/network_activity_indicator_tab_helper.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/web/sad_tab_tab_helper.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/chrome/browser/web/sad_tab_tab_helper.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/clean/chrome/app/steps/launch_to_background.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/clean/chrome/app/steps/root_coordinator+application_step.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/browser_state.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/public/test/test_redirect_observer.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/public/web_state/web_state_user_data.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/web_state/ui/wk_back_forward_list_item_holder.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/web_state/ui/wk_back_forward_list_item_holder.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/web_state/ui/wk_web_view_configuration_provider.h
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/web_state/ui/wk_web_view_configuration_provider.mm
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web/webui/url_data_manager_ios.cc
[modify] https://crrev.com/37c9356daeb495268f0ccc950c2c8095c0edd0e9/ios/web_view/internal/translate/web_view_translate_client.h
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/509a04187b65fc65c561d81af3ee3ede268584f3

commit 509a04187b65fc65c561d81af3ee3ede268584f3
Author: avi <avi@chromium.org>
Date: Fri Apr 28 17:03:43 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2845263002
Cr-Commit-Position: refs/heads/master@{#468031}

[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/background_contents_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/devtools_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/extension_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/guest_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/prerender_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/printing_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/tab_contents_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/providers/web_contents/web_contents_tag.h
[modify] https://crrev.com/509a04187b65fc65c561d81af3ee3ede268584f3/chrome/browser/task_manager/web_contents_tags.cc
Project Member

Comment 13 by bugdroid1@chromium.org, Apr 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a402eb1482f1884d7aac7ed59c0da27980ec4c5

commit 4a402eb1482f1884d7aac7ed59c0da27980ec4c5
Author: avi <avi@chromium.org>
Date: Fri Apr 28 21:19:08 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2848703004
Cr-Commit-Position: refs/heads/master@{#468128}

[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/chrome/browser/android/offline_pages/downloads/offline_page_download_bridge.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/chrome/browser/android/offline_pages/offline_page_bridge.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/chrome/browser/android/offline_pages/offline_page_request_job.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/chrome/browser/android/offline_pages/offline_page_utils_unittest.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/content/suggested_articles_observer.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/content/suggested_articles_observer.h
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/core/background/network_quality_provider_stub.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/core/background/network_quality_provider_stub.h
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/core/downloads/download_notifying_observer.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/core/downloads/download_ui_adapter.cc
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/core/downloads/download_ui_adapter.h
[modify] https://crrev.com/4a402eb1482f1884d7aac7ed59c0da27980ec4c5/components/offline_pages/core/recent_tabs/recent_tabs_ui_adapter_delegate.cc
Project Member

Comment 19 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e8937a55f7f21754924801c7b376c242d0722d01

commit e8937a55f7f21754924801c7b376c242d0722d01
Author: avi <avi@chromium.org>
Date: Tue May 02 02:17:20 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2847173004
Cr-Commit-Position: refs/heads/master@{#468535}

[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/autofill/save_card_bubble_controller_impl.h
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/browser_instant_controller.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/browser_tab_restorer.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/cocoa/tab_dialogs_cocoa.mm
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/exclusive_access/fullscreen_within_tab_helper.h
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/passwords/manage_passwords_ui_controller_mock.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/passwords/manage_passwords_ui_controller_unittest.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/tab_helpers.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/tabs/tab_strip_model_stats_recorder.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/tabs/tab_strip_model_unittest.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/views/download/download_feedback_dialog_view.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/views/tab_dialogs_views.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/views/tabs/tab_drag_controller_interactive_uitest.cc
[modify] https://crrev.com/e8937a55f7f21754924801c7b376c242d0722d01/chrome/browser/ui/webui/constrained_web_dialog_ui.cc
Project Member

Comment 20 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8945fc9391e28e47d7b948907f7ae76b1b3e33b1

commit 8945fc9391e28e47d7b948907f7ae76b1b3e33b1
Author: avi <avi@chromium.org>
Date: Tue May 02 16:03:23 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2851003002
Cr-Commit-Position: refs/heads/master@{#468654}

[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/data_reduction_proxy/core/browser/data_reduction_proxy_data.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/data_use_measurement/core/data_use_measurement.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/data_use_measurement/core/data_use_measurement_unittest.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/data_use_measurement/core/data_use_network_delegate_unittest.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/feature_engagement_tracker/internal/android/feature_engagement_tracker_impl_android.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/guest_view/browser/guest_view_manager.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/navigation_interception/intercept_navigation_delegate.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/offline_items_collection/core/android/offline_content_aggregator_bridge.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/password_manager/content/browser/content_password_manager_driver_factory.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/pdf/browser/pdf_web_contents_helper.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/pdf/browser/pdf_web_contents_helper.h
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/renderer_context_menu/context_menu_delegate.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/safe_browsing/base_ui_manager.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/sessions/content/content_live_tab.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/sessions/ios/ios_live_tab.mm
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/user_prefs/user_prefs.cc
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/user_prefs/user_prefs.h
[modify] https://crrev.com/8945fc9391e28e47d7b948907f7ae76b1b3e33b1/components/zoom/zoom_event_manager.cc
Project Member

Comment 21 by bugdroid1@chromium.org, May 2 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/778483e30c90f04a1674c1ded8507e226e7db27d

commit 778483e30c90f04a1674c1ded8507e226e7db27d
Author: avi <avi@chromium.org>
Date: Tue May 02 16:22:16 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2843323002
Cr-Commit-Position: refs/heads/master@{#468670}

[modify] https://crrev.com/778483e30c90f04a1674c1ded8507e226e7db27d/gin/modules/module_registry.cc
[modify] https://crrev.com/778483e30c90f04a1674c1ded8507e226e7db27d/storage/browser/blob/blob_url_request_job_factory.cc
[modify] https://crrev.com/778483e30c90f04a1674c1ded8507e226e7db27d/ui/web_dialogs/web_dialog_ui.cc
Project Member

Comment 22 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/284ec61c76d48490010b2f1c80628306d4d75a7f

commit 284ec61c76d48490010b2f1c80628306d4d75a7f
Author: avi <avi@chromium.org>
Date: Wed May 03 01:52:23 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 

Review-Url: https://codereview.chromium.org/2846333004
Cr-Commit-Position: refs/heads/master@{#468862}

[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/autocomplete/shortcuts_backend_factory.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/banners/app_banner_manager_desktop.h
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/data_usage/tab_id_annotator.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/data_use_measurement/chrome_data_use_ascriber.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/data_use_measurement/data_use_web_contents_observer.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/font_family_cache.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/infobars/infobar_service.h
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/loader/chrome_navigation_data.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/metrics/desktop_session_duration/desktop_session_duration_observer.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/metrics/renderer_uptime_web_contents_observer.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/net/nss_context_chromeos.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/ntp_snippets/bookmark_last_visit_updater.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/page_load_metrics/metrics_web_contents_observer.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/password_manager/chrome_password_manager_client.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/password_manager/password_manager_test_base.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/profiles/profile_android.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/search/instant_io_context.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/ssl/ssl_error_handler.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/ssl/ssl_error_handler.h
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/supervised_user/supervised_user_interstitial.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/supervised_user/supervised_user_interstitial.h
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/sync/sessions/sync_sessions_router_tab_helper.cc
[modify] https://crrev.com/284ec61c76d48490010b2f1c80628306d4d75a7f/chrome/browser/tracing/navigation_tracing.h
Project Member

Comment 24 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cb129c01ece3b6201a3baeceeb5b988fa49ef1be

commit cb129c01ece3b6201a3baeceeb5b988fa49ef1be
Author: avi <avi@chromium.org>
Date: Wed May 03 06:49:29 2017

Switch SupportsUserData uses to use unique_ptr.

The interface taking a raw pointer is deprecated and being removed.

BUG= 690937 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2853663002
Cr-Commit-Position: refs/heads/master@{#468909}

[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/android/content_view_core_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/android/context_selection_client.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/android/java/gin_java_bridge_message_filter.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/blob_storage/chrome_blob_storage_context.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/browser_context.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/frame_host/render_frame_host_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/loader/resource_dispatcher_host_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/loader/resource_dispatcher_host_unittest.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/media/session/media_session_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/media/session/media_session_impl.h
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/renderer_host/render_process_host_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/service_worker/service_worker_request_handler.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/service_worker/service_worker_write_to_cache_job.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/site_instance_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/browser/websockets/websocket_manager.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/public/browser/web_contents_user_data.h
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/renderer/internal_document_state_data.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/renderer/internal_document_state_data.h
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/renderer/mojo_bindings_controller.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/test/web_contents_observer_sanity_checker.cc
[modify] https://crrev.com/cb129c01ece3b6201a3baeceeb5b988fa49ef1be/content/test/web_contents_observer_sanity_checker.h
Project Member

Comment 25 by bugdroid1@chromium.org, May 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a86f3e33aeeb1e7d0d98319c8000ebd0a20bcabf

commit a86f3e33aeeb1e7d0d98319c8000ebd0a20bcabf
Author: avi <avi@chromium.org>
Date: Wed May 03 19:38:26 2017

Remove the deprecated raw-pointer call from SupportsUserData

BUG= 690937 

Review-Url: https://codereview.chromium.org/2860613003
Cr-Commit-Position: refs/heads/master@{#469079}

[modify] https://crrev.com/a86f3e33aeeb1e7d0d98319c8000ebd0a20bcabf/base/supports_user_data.cc
[modify] https://crrev.com/a86f3e33aeeb1e7d0d98319c8000ebd0a20bcabf/base/supports_user_data.h

Comment 26 by a...@chromium.org, May 4 2017

Cc: sdefresne@chromium.org
Owner: a...@chromium.org
Status: Fixed (was: Started)
►

Sign in to add a comment