New issue
Advanced search Search tips

Issue 690929 link

Starred by 1 user
Status: Fixed
Owner:
altimin@chromium.org
Closed: Jun 2017
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug

Blocking:
issue 639852
issue 650594


Show other hotlists

Hotlists containing this issue:
TaskThrottling


Sign in to add a comment

Active WebRTC connection should grant exception from budget-based throttling

Project Member Reported by altimin@chromium.org, Feb 10 2017 
Active WebRTC connection should grant exception from budget-based throttling

Comment 3 by altimin@chromium.org, Feb 13 2017

Labels: -Pri-3 Merge-Request-57 OS-All Pri-1
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 13 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 13 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb1631705160cba7c83a70393aba982719f60726

commit eb1631705160cba7c83a70393aba982719f60726
Author: Alexander Timin <altimin@chromium.org>
Date: Mon Feb 13 16:10:38 2017

[scheduler] Plumb information about active webrtc connections to scheduler

Notify scheduler about webrtc connections.

BUG= 690929 

Review-Url: https://codereview.chromium.org/2683993006
Cr-Commit-Position: refs/heads/master@{#449640}
(cherry picked from commit 407bdb243f9dd1d94f7e99318a7f60df1f421dfa)

Review-Url: https://codereview.chromium.org/2692013002 .
Cr-Commit-Position: refs/branch-heads/2987@{#474}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/eb1631705160cba7c83a70393aba982719f60726/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/eb1631705160cba7c83a70393aba982719f60726/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/eb1631705160cba7c83a70393aba982719f60726/third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/713fc83963cd96d58851a2ce5f8f2de6007324a2

commit 713fc83963cd96d58851a2ce5f8f2de6007324a2
Author: altimin <altimin@chromium.org>
Date: Mon Feb 13 19:09:33 2017

Revert of [scheduler] Plumb information about active webrtc connections to scheduler (patchset #1 id:1 of https://codereview.chromium.org/2692013002/ )

Reason for revert:
Broke continuous build (bad merge).

Original issue's description:
> [scheduler] Plumb information about active webrtc connections to scheduler
>
> Notify scheduler about webrtc connections.
>
> BUG= 690929 
>
> Review-Url: https://codereview.chromium.org/2683993006
> Cr-Commit-Position: refs/heads/master@{#449640}
> (cherry picked from commit 407bdb243f9dd1d94f7e99318a7f60df1f421dfa)
>
> Review-Url: https://codereview.chromium.org/2692013002 .
> Cr-Commit-Position: refs/branch-heads/2987@{#474}
> Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
> Committed: https://chromium.googlesource.com/chromium/src/+/eb1631705160cba7c83a70393aba982719f60726

TBR=
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 690929 

Review-Url: https://codereview.chromium.org/2694013002
Cr-Commit-Position: refs/branch-heads/2987@{#480}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/713fc83963cd96d58851a2ce5f8f2de6007324a2/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/713fc83963cd96d58851a2ce5f8f2de6007324a2/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/713fc83963cd96d58851a2ce5f8f2de6007324a2/third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp
Project Member

Comment 7 by bugdroid1@chromium.org, Feb 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1649531ca39760174c18c57ef8fccefa44fc307c

commit 1649531ca39760174c18c57ef8fccefa44fc307c
Author: Alexander Timin <altimin@chromium.org>
Date: Tue Feb 14 00:06:01 2017

[scheduler] Plumb information about active webrtc connections to scheduler

Notify scheduler about webrtc connections.

BUG= 690929 

Review-Url: https://codereview.chromium.org/2683993006
Cr-Commit-Position: refs/heads/master@{#449640}
(cherry picked from commit 407bdb243f9dd1d94f7e99318a7f60df1f421dfa)

Review-Url: https://codereview.chromium.org/2697603004 .
Cr-Commit-Position: refs/branch-heads/2987@{#491}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/1649531ca39760174c18c57ef8fccefa44fc307c/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp
[modify] https://crrev.com/1649531ca39760174c18c57ef8fccefa44fc307c/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.h
[modify] https://crrev.com/1649531ca39760174c18c57ef8fccefa44fc307c/third_party/WebKit/Source/web/tests/ActiveConnectionThrottlingTest.cpp

Comment 8 by skyos...@chromium.org, Jun 22 2017

Status: Fixed (was: Started)
I believe this is done.
►

Sign in to add a comment