New issue
Advanced search Search tips

Issue 690920 link

Starred by 2 users
Status: Fixed
Owner:
vasi...@chromium.org
Closed: Mar 2017
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 666340



Sign in to add a comment

Account chooser should reuse the (i) icon with tooltip from the CVC dialog

Project Member Reported by vasi...@chromium.org, Feb 10 2017 
The UX team requested that the account chooser uses the same implementation of the icon with the tooltip for the PSL credentials. The icon should be (i) in both dialogs (https://groups.google.com/a/google.com/forum/#!msg/chrome-yolo-core/VIQGEwQD2rM/OjeVgI-2CgAJ).
An additional requirement from the security team is that the icon doesn't propagate the mouse click to the underlying view (thus, choosing a credential).

Comment 1 by vasi...@chromium.org, Feb 10 2017 

Linux, first pass.
Screenshot from 2017-02-10 14:41:50.png
17.2 KB View Download
Screenshot from 2017-02-10 14:41:42.png
19.0 KB View Download

Comment 2 by vasi...@chromium.org, Feb 15 2017 

Linux, second pass
Screenshot from 2017-02-15 17:03:52.png
17.2 KB View Download
Screenshot from 2017-02-15 17:03:44.png
17.5 KB View Download

Comment 3 by vasi...@chromium.org, Feb 15 2017 

The CVC dialog
Screenshot from 2017-02-15 17:23:42.png
22.5 KB View Download
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/864f2986aa206bae957944685e1bbb0d7b4fdcc4

commit 864f2986aa206bae957944685e1bbb0d7b4fdcc4
Author: vasilii <vasilii@chromium.org>
Date: Fri Feb 17 09:45:04 2017

Make the account chooser and CVC dialog use the same icon with toolip for Views.

The CL changes the icon to (i). The account chooser reuses the implementation of the icon and the tooltip for the CVC dialog.

BUG= 690920 

Review-Url: https://codereview.chromium.org/2684343006
Cr-Commit-Position: refs/heads/master@{#451273}

[modify] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/chrome/browser/ui/views/autofill/card_unmask_prompt_views.cc
[delete] https://crrev.com/c125f77ab44ad504b5dd8171958aeece8410541e/chrome/browser/ui/views/autofill/info_bubble.cc
[delete] https://crrev.com/c125f77ab44ad504b5dd8171958aeece8410541e/chrome/browser/ui/views/autofill/info_bubble.h
[delete] https://crrev.com/c125f77ab44ad504b5dd8171958aeece8410541e/chrome/browser/ui/views/autofill/tooltip_icon.cc
[modify] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/chrome/browser/ui/views/passwords/credentials_item_view.cc
[modify] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/chrome/browser/ui/views/passwords/credentials_item_view.h
[modify] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/ui/views/BUILD.gn
[add] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/ui/views/bubble/info_bubble.cc
[add] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/ui/views/bubble/info_bubble.h
[add] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/ui/views/bubble/tooltip_icon.cc
[rename] https://crrev.com/864f2986aa206bae957944685e1bbb0d7b4fdcc4/ui/views/bubble/tooltip_icon.h

Comment 5 by vasi...@chromium.org, Feb 21 2017 

Mac screenshots
Screen Shot 2017-02-21 at 14.26.37.png
35.4 KB View Download
Screen Shot 2017-02-20 at 17.55.35.png
53.5 KB View Download
Screen Shot 2017-02-20 at 17.55.21.png
23.5 KB View Download
Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64229f842420145f8cc6ba4c35298f45b27d282d

commit 64229f842420145f8cc6ba4c35298f45b27d282d
Author: vasilii <vasilii@chromium.org>
Date: Wed Mar 01 18:05:28 2017

Use (i) icon and the same tooltip for the credit cards dialog and account chooser on Mac.

BUG= 690920 

Review-Url: https://codereview.chromium.org/2703253007
Cr-Commit-Position: refs/heads/master@{#453972}

[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/autofill/autofill_bubble_controller.h
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/autofill/autofill_bubble_controller.mm
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/autofill/autofill_dialog_constants.h
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.h
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/autofill/autofill_tooltip_controller.mm
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/passwords/account_chooser_view_controller.mm
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/passwords/credential_item_button.h
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/chrome/browser/ui/cocoa/passwords/credential_item_button.mm
[modify] https://crrev.com/64229f842420145f8cc6ba4c35298f45b27d282d/components/resources/autofill_scaled_resources.grdp

Comment 7 by vasi...@chromium.org, Mar 2 2017

Status: Fixed (was: Started)
►

Sign in to add a comment