New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690919 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

!has_rest_ in scopes.cc

Project Member Reported by ClusterFuzz, Feb 10 2017

Issue description

Cc: msrchandra@chromium.org
Labels: Test-Predator-Wrong M-58
Owner: marja@chromium.org
Status: Assigned (was: Untriaged)
Predator did not provide any possible suspect. Assigning to the concern owner from CL.
https://chromium.googlesource.com/v8/v8/+log/b8c7870c1e803612bdcacaea3359627e5235155d..82e43bfed861c6fc31df1b401f6058d253ffa6d6?pretty=fuller

@marja -- Could you please look into the issue, kindly re-assign if this is not related to your changes.
Thank You.

Comment 2 by marja@chromium.org, Feb 10 2017

Yeah, this is my stuff.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/ded4cae2c2eccc559e2d0db24872d9f1d450f665

commit ded4cae2c2eccc559e2d0db24872d9f1d450f665
Author: Marja Hölttä <marja@chromium.org>
Date: Fri Feb 10 18:49:06 2017

[parsing] Fix rest parameter handling in preparser.

Since preparser creates different scopes than the parser, the invariant "at most one rest parameter" doesn't hold when the rest param is a destructuring param.

No new tests added; the problem is visible w/ existing tests with FLAG_lazy_inner_functions on.

R=​vogelheim@chromium.org
BUG= chromium:690919 

Change-Id: I525b8dfee92acd0733702c5a940a1a83a94712df
Reviewed-on: https://chromium-review.googlesource.com/440925
Reviewed-by: Daniel Vogelheim <vogelheim@chromium.org>
Commit-Queue: Marja Hölttä <marja@chromium.org>
Cr-Commit-Position: refs/heads/master@{#43117}
[modify] https://crrev.com/ded4cae2c2eccc559e2d0db24872d9f1d450f665/src/ast/scopes.cc

Project Member

Comment 4 by ClusterFuzz, Feb 11 2017

ClusterFuzz has detected this issue as fixed in range 43116:43117.

Detailed report: https://cluster-fuzz.appspot.com/testcase?key=6509855193169920

Fuzzer: mbarbella_js_mutation
Job Type: linux_asan_d8_v8_arm_dbg
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !has_rest_ in scopes.cc
  
Sanitizer: address (ASAN)

Regressed: V8: 43085:43086
Fixed: V8: 43116:43117

Reproducer Testcase: https://cluster-fuzz.appspot.com/download/AMIfv97EEvheme0Hd5Q1iq7y10y-4jGr1nJ_s79YZ1y9FzoBkvfTpy73cq3GYVoXY58lcy4s61RW53D_mzHoDyb45eNT6lozGnu0Uuk_lAyXzebdiBDK_er4KMcIrd6gignvVae3OsnWRK5kwNAroiqLbtNVc_UQey0oGj43Bsibd7lF_MPvaRLAfvV7IBvOpSfsQ8M-xJ-AIfTszuBG9VbRQ3zKvbUV7oSV8Q4C9EX8kkBvmE8C77SC6Qn03lkwtdgaVsPdEKpCoFYUdklyj053b5gaP0_BX4IKo8n0-VJ6E7_GRZDGuRXXfG9txextVa2iFHWebKNLJedhont42SXICiFsoSwQ5ao-YwpFpblitCX8angJgjboBaUN2QtQ5qx1vv_p8_gR-zpH4SDLuKK-QBh1brQViA?testcase_id=6509855193169920


See https://dev.chromium.org/Home/chromium-security/bugs/reproducing-clusterfuzz-bugs for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 5 by ClusterFuzz, Feb 11 2017

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 6509855193169920 is verified as fixed, so closing issue.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment