New issue
Advanced search Search tips

Issue 690852 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----



Sign in to add a comment

Links to luci-milo for internal bots broken

Project Member Reported by perezju@chromium.org, Feb 10 2017

Issue description

Problem with Sheriff-o-Matic:

For example a link to a failure on chrome-proxy-tests points to:
https://luci-milo.appspot.com/i/internal.client.clank/chrome-proxy-tests

The correct link should be:
https://luci-milo.appspot.com/buildbot/internal.client.clank/chrome-proxy-tests/

 
Labels: Milestone-UX
Status: Available (was: Untriaged)
Thanks for the bug report! This shouldn't be difficult to fix though I want to verify first that /buildbot/ should be used in all internal bot links rather than a subset. 
Quickly skimming through https://luci-milo.appspot.com/ looks like all bot links are of the form:

https://luci-milo.appspot.com/buildbot/{master}/{builder_name}/

Owner: zhangtiff@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jun 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/d6f0ecc937adbd5a57521481273a0936679b87d4

commit d6f0ecc937adbd5a57521481273a0936679b87d4
Author: Tiff Zhang <zhangtiff@google.com>
Date: Mon Jun 26 22:50:44 2017

SoM: Fix internal builder links for milo.

Bug:690852
Change-Id: Idc6663a317836abd1b76f8f7209c7be6ac01a1a1
Reviewed-on: https://chromium-review.googlesource.com/549091
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Tiffany Zhang <zhangtiff@chromium.org>

[modify] https://crrev.com/d6f0ecc937adbd5a57521481273a0936679b87d4/go/src/infra/appengine/sheriff-o-matic/frontend/elements/som-linkify-behavior.html

Status: Fixed (was: Assigned)
This should be out with the next release (tomorrow). Sorry for the delay on fixing this; I had forgotten about this bug. 

Sign in to add a comment