How to handle pages with space only titles? |
|||
Issue descriptionIf the page title is empty, we currently show the URL. But if the page title is only whitespace, it is possible to have an empty title in the Reading List View. I think this is WAI as the page can set title to whitespace. But this can look like a bug to the user, specially if this white title is a page bug. e.g.: https://drive.google.com/file/d/0B-xmXLQhjeKuWmRZenhMZ094RG8/view In this case, the page title is sometimes empty and is set to the normal title after a delay. Thanks srikanthg@ for reporting
,
Feb 13 2017
I can reproduce the bug on http://www.faz.net/aktuell/politik/inland/16-punkte-plan-merkel-will-mit-abschiebungen-zur-freiwilligen-ausreise-motivieren-14870494.html only on iPad pro. The title after distillation starts with a new line, which cause the issue. I am doing a CL to handle this case, but I think this can be considered as a website bug.
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9e87351607a343f906b1866ea41767434986ebbe commit 9e87351607a343f906b1866ea41767434986ebbe Author: olivierrobin <olivierrobin@chromium.org> Date: Tue Feb 14 12:11:10 2017 [Reading List iOS] Collapse whitespace on item title. When adding an entry or after distillation, set collapse whitespaces on titles to remove new lines and consecutive spaces. BUG= 690845 Review-Url: https://codereview.chromium.org/2690003004 Cr-Commit-Position: refs/heads/master@{#450328} [modify] https://crrev.com/9e87351607a343f906b1866ea41767434986ebbe/components/reading_list/ios/reading_list_model_impl.cc [modify] https://crrev.com/9e87351607a343f906b1866ea41767434986ebbe/components/reading_list/ios/reading_list_model_unittest.mm [modify] https://crrev.com/9e87351607a343f906b1866ea41767434986ebbe/ios/chrome/browser/reading_list/reading_list_download_service.cc [modify] https://crrev.com/9e87351607a343f906b1866ea41767434986ebbe/ios/chrome/browser/ui/reading_list/reading_list_collection_view_controller.mm
,
Feb 14 2017
This is fixed. As this is a not blocking edge case, I think it is fine keeping it on M-58.
,
Feb 21 2017
https://drive.google.com/open?id=0B6GVWQnhaMCleEQyc25oNmlEM1E Looks good. Verified on iPhone 6+ iOS 10.2, iPad Pro iOS 10.1.1 on build 58.0.3019.0 Canary |
|||
►
Sign in to add a comment |
|||
Comment 1 by gambard@chromium.org
, Feb 10 2017