New issue
Advanced search Search tips

Issue 690829 link

Starred by 1 user
Status: Fixed
Owner:
olivierrobin@chromium.org
Closed: Feb 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Distillation of pages with invalid images fail

Project Member Reported by olivierrobin@chromium.org, Feb 10 2017 
e.g. page with and <img> pointing to a wrong URL.
A better behavior would be to just skip the image.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/182bfc3b6cd2c7536577752dfbf032e42207b34f

commit 182bfc3b6cd2c7536577752dfbf032e42207b34f
Author: olivierrobin <olivierrobin@chromium.org>
Date: Fri Feb 10 10:26:27 2017

[iOS Reading List] Skip invalid iages in distillation.

If an image is invalid (e.g. src pointing to not existing URL), the
current behavior is to fail the whole distillation.
Just skip the image instead (as normal rendering would do).
Replace src by empty string to avoid network acces when displaying
offline page.

BUG= 690829 

Review-Url: https://codereview.chromium.org/2683393002
Cr-Commit-Position: refs/heads/master@{#449577}

[modify] https://crrev.com/182bfc3b6cd2c7536577752dfbf032e42207b34f/ios/chrome/browser/reading_list/url_downloader.cc

Comment 2 by olivierrobin@chromium.org, Feb 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment