New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690824 link

Starred by 2 users
Status: WontFix
Owner:
glevin@chromium.org
Closed: Mar 2017
Cc:
█ elizabethchiu@chromium.org
ajha@chromium.org
█ kavvaru@chromium.org
█ brajkumar@chromium.org
mmanchala@chromium.org
█ durga.behera@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessary default focus is seen on 'Add Supervised user' option

Project Member Reported by mmanchala@chromium.org, Feb 10 2017 
Chrome Version: 58.0.3007.0/9268.0.0 dev-channel Jerry, Peach-Pit, Quawks
OS: Chrome

What steps will reproduce the problem?
(1)Sign in to user -> Sign out -> Now in Profiles page Click on 3 dot menu so that 'Add Supervised User' Button is seen
(2)Now observe default Blue focus ring is seen (Please refer Video and screenshot)

Expected: Default Focus ring should not be seen on 'Add Supervised user' option. 
Actual: Instead Default Focus ring is seen 

This is Regression issue as same is working fine in 58.0.2998.0/9245.0.0 dev-channel Gnawty

@glevin : Please confirm the Behavior
Actual_DefaultFocus.mp4
5.3 MB View Download
Actual_Defaultfocus.jpg
294 KB View Download
Expected_NoFocus.mp4
2.2 MB View Download
Expected_NoFocus.jpg
376 KB View Download

Comment 1 by glevin@chromium.org, Feb 24 2017

Cc: elizabethchiu@chromium.org
This is a result of  Issue 642330 , and I would argue that it's working as intended.  I suppose the focus ring isn't *necessary*, per se, in this case.  But when you click the [...] button, "Add supervised user" *does* have focus (you can verify this by pressing ENTER).  And when UI elements have focus, we draw a focus highlight around them.

+elizabethchiu@, who was looking at the UX for this feature.  Elizabeth- do you have any problem with this behavior, or would you call this WAI?

Comment 2 by glevin@chromium.org, Mar 6 2017

Cc: mmanchala@chromium.org
Status: WontFix (was: Assigned)
WAI, in the absence of any feedback to the contrary

Comment 3 by elizabethchiu@chromium.org, Mar 7 2017 

I think right now the padding of the button is a bit too much. They should be similar to "exit session" button as attached.
Screen Shot 2017-03-06 at 6.59.40 PM.png
436 KB View Download

Comment 4 by glevin@chromium.org, Mar 8 2017 

Which spacing?  The left/right padding inside the button, on either side of the text?  Based on the attached image, all other padding around this button is about the same.  At the moment, the button is hard-coded at 180px.

Assuming that this is what you're looking for, I'm going to leave this issue closed, and submit a new one for cleaning up the spacing on the button, as that's unrelated to the focus rectangle.
AddSupUser_spacing.png
30.8 KB View Download

Comment 5 by elizabethchiu@chromium.org, Mar 8 2017 

Can we change 30dp padding to 16dp?

Comment 6 by glevin@chromium.org, Mar 9 2017 

Sure.  I filed  Issue 700064 , since it's pretty much an entirely different issue from the initial report here.  Leaving this one closed.

Comment 7 by benhenry@chromium.org, Sep 29 2017

Components: Blink>HTML>Focus

Comment 8 by benhenry@chromium.org, Sep 29 2017

Components: -Blink>Focus
►

Sign in to add a comment