New issue
Advanced search Search tips

Issue 690816 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Task

Blocking:
issue 690809



Sign in to add a comment

WTF: Document Vector

Project Member Reported by yutak@chromium.org, Feb 10 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Feb 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fccdd68d3d2bd3d7190e0f0824ed44e21e3b6328

commit fccdd68d3d2bd3d7190e0f0824ed44e21e3b6328
Author: yutak <yutak@chromium.org>
Date: Mon Feb 13 09:13:44 2017

WTF: Update comments for Vector.

Note that the comments are not comprehensive enough yet. They will be updated
incrementally.

BUG=690816
TBR=tzik@chromium.org

Review-Url: https://codereview.chromium.org/2690953002
Cr-Commit-Position: refs/heads/master@{#449921}

[modify] https://crrev.com/fccdd68d3d2bd3d7190e0f0824ed44e21e3b6328/third_party/WebKit/Source/wtf/Vector.h

Project Member

Comment 2 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6cfc1a979decf08475dcef3b095c8af9c8f2649

commit e6cfc1a979decf08475dcef3b095c8af9c8f2649
Author: yutak <yutak@chromium.org>
Date: Wed Feb 15 11:40:46 2017

WTF::Vector: Add comments to each member function.

This patch adds lots of comments to the public member functions of Vector.
Additionally, the order of the member functions is changed slightly, and
some inlined implementation becomes out-of-line, both for readability.

It still lacks class-level commentary, including the precise semantics of
iterator invalidation or the explanation of inline capacity. This will be
addressed later.

BUG=690816

Review-Url: https://codereview.chromium.org/2696123002
Cr-Commit-Position: refs/heads/master@{#450669}

[modify] https://crrev.com/e6cfc1a979decf08475dcef3b095c8af9c8f2649/third_party/WebKit/Source/wtf/Vector.h

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/360b16ec95b18a11357e354b3b3db1080264f757

commit 360b16ec95b18a11357e354b3b3db1080264f757
Author: yutak <yutak@chromium.org>
Date: Thu Feb 23 09:40:47 2017

WTF::Vector: Add detailed explanation as class-level comments.

This change should cover almost all the use cases and common traps of Vector.

BUG=690816

Review-Url: https://codereview.chromium.org/2712643002
Cr-Commit-Position: refs/heads/master@{#452443}

[modify] https://crrev.com/360b16ec95b18a11357e354b3b3db1080264f757/third_party/WebKit/Source/wtf/Vector.h

Sign in to add a comment