New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690807 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Feature



Sign in to add a comment

Change ios/web_view class prefix to CWV.

Project Member Reported by michaeldo@chromium.org, Feb 10 2017

Issue description

CRIWV was a temporary class prefix. Update to CWV instead as that has been decided upon for the new prefix of the ios/web_view classes.
 
Description: Show this description
Summary: Change ios/web_view class prefix to CWV. (was: Change ios/web_view class prefix to CRW.)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c3140e57a046a9f8d5ce1d26aeefc548b960f88

commit 8c3140e57a046a9f8d5ce1d26aeefc548b960f88
Author: michaeldo <michaeldo@chromium.org>
Date: Tue Feb 14 05:44:14 2017

Rename CRIWVWebsiteDataStore to CWVWebsiteDataStore.

BUG= 690807 

Review-Url: https://codereview.chromium.org/2697453007
Cr-Commit-Position: refs/heads/master@{#450274}

[modify] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/internal/BUILD.gn
[modify] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/internal/criwv.mm
[modify] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/internal/criwv_web_view_configuration.mm
[delete] https://crrev.com/e26c0958d87bd7b1b43d83310e96323156696d3f/ios/web_view/internal/criwv_website_data_store_internal.h
[modify] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/internal/cwv_web_view.mm
[rename] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/internal/cwv_website_data_store.mm
[add] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/internal/cwv_website_data_store_internal.h
[modify] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/public/BUILD.gn
[modify] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/public/criwv_web_view_configuration.h
[rename] https://crrev.com/8c3140e57a046a9f8d5ce1d26aeefc548b960f88/ios/web_view/public/cwv_website_data_store.h

Project Member

Comment 6 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb

commit a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb
Author: michaeldo <michaeldo@chromium.org>
Date: Tue Feb 14 21:07:48 2017

Rename ios/web_view public delegates from CRIWV to CWV prefix.

BUG= 690807 

Review-Url: https://codereview.chromium.org/2691883003
Cr-Commit-Position: refs/heads/master@{#450471}

[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv.mm
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv_web_client.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv_web_client.mm
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv_web_main_delegate.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv_web_main_delegate.mm
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv_web_main_parts.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/criwv_web_main_parts.mm
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/translate/criwv_translate_client.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/internal/translate/criwv_translate_client.mm
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/public/BUILD.gn
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/public/criwv.h
[rename] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/public/cwv_delegate.h
[rename] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/public/cwv_translate_delegate.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/public/cwv_web_view.h
[rename] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/public/cwv_web_view_delegate.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/shell/shell_delegate.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/shell/shell_view_controller.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/shell/shell_view_controller.m
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/shell/translate_controller.h
[modify] https://crrev.com/a8d433d5af46c3b6d3e2ba57d0325f5045dc15bb/ios/web_view/shell/translate_controller.m

Project Member

Comment 7 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f9cb6a502f37bb663d158bcb09a0a231f8519e64

commit f9cb6a502f37bb663d158bcb09a0a231f8519e64
Author: michaeldo <michaeldo@chromium.org>
Date: Fri Feb 24 19:50:48 2017

Rename CRIWV class to CWV.

BUG= 690807 

Review-Url: https://codereview.chromium.org/2703413004
Cr-Commit-Position: refs/heads/master@{#452907}

[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/BUILD.gn
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/criwv_browser_state.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/criwv_network_delegate.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/criwv_url_request_context_getter.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/criwv_web_client.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/criwv_web_main_delegate.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/criwv_web_main_parts.h
[rename] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/internal/cwv.mm
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/public/BUILD.gn
[delete] https://crrev.com/eda3863d1963478c04b05d846f3ce34cac5283ee/ios/web_view/public/criwv.h
[add] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/public/cwv.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/public/cwv_delegate.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/public/cwv_web_view.h
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/shell/shell_app_delegate.m
[modify] https://crrev.com/f9cb6a502f37bb663d158bcb09a0a231f8519e64/ios/web_view/shell/shell_view_controller.m

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/01ec0eb96c86261cb26219d4bd227f98d94c06d5

commit 01ec0eb96c86261cb26219d4bd227f98d94c06d5
Author: michaeldo <michaeldo@chromium.org>
Date: Sat Feb 25 09:08:38 2017

Replace prefix of ios/web_view C++ classes.

The C++ classes in ios/web_view should begin with the prefix "WebView"
instead of an Objective-C style prefix.

BUG= 690807 

Review-Url: https://codereview.chromium.org/2715043002
Cr-Commit-Position: refs/heads/master@{#453082}

[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/BUILD.gn
[delete] https://crrev.com/63bed5d51cd3568a418f8bc72d7d86de0fff8222/ios/web_view/internal/criwv_network_delegate.cc
[delete] https://crrev.com/63bed5d51cd3568a418f8bc72d7d86de0fff8222/ios/web_view/internal/criwv_web_client.h
[delete] https://crrev.com/63bed5d51cd3568a418f8bc72d7d86de0fff8222/ios/web_view/internal/criwv_web_client.mm
[delete] https://crrev.com/63bed5d51cd3568a418f8bc72d7d86de0fff8222/ios/web_view/internal/criwv_web_main_delegate.h
[delete] https://crrev.com/63bed5d51cd3568a418f8bc72d7d86de0fff8222/ios/web_view/internal/criwv_web_main_delegate.mm
[delete] https://crrev.com/63bed5d51cd3568a418f8bc72d7d86de0fff8222/ios/web_view/internal/criwv_web_main_parts.h
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/cwv.mm
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/cwv_website_data_store.mm
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/cwv_website_data_store_internal.h
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/translate/criwv_translate_accept_languages_factory.cc
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/translate/criwv_translate_accept_languages_factory.h
[modify] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/translate/criwv_translate_client.mm
[rename] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_browser_state.h
[rename] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_browser_state.mm
[add] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_network_delegate.cc
[rename] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_network_delegate.h
[rename] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_url_request_context_getter.h
[rename] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_url_request_context_getter.mm
[add] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_web_client.h
[add] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_web_client.mm
[add] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_web_main_delegate.h
[add] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_web_main_delegate.mm
[add] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_web_main_parts.h
[rename] https://crrev.com/01ec0eb96c86261cb26219d4bd227f98d94c06d5/ios/web_view/internal/web_view_web_main_parts.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Feb 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d75fa82cc20aac57093fd756c2f629750a36eaa

commit 3d75fa82cc20aac57093fd756c2f629750a36eaa
Author: michaeldo <michaeldo@chromium.org>
Date: Sat Feb 25 17:20:31 2017

Update class prefixes in ios/web_view/translate.

BUG= 690807 

Review-Url: https://codereview.chromium.org/2714223004
Cr-Commit-Position: refs/heads/master@{#453097}

[modify] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/cwv_web_view.mm
[modify] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/BUILD.gn
[delete] https://crrev.com/98eb8962d85b8c426602f89e6e31358b40e46bab/ios/web_view/internal/translate/criwv_translate_manager_impl.h
[add] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/cwv_translate_manager_impl.h
[rename] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/cwv_translate_manager_impl.mm
[rename] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.cc
[rename] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/web_view_translate_accept_languages_factory.h
[rename] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/web_view_translate_client.h
[rename] https://crrev.com/3d75fa82cc20aac57093fd756c2f629750a36eaa/ios/web_view/internal/translate/web_view_translate_client.mm

Status: Fixed (was: Started)

Sign in to add a comment