New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690759 link

Starred by 1 user

Issue metadata

Status: Duplicate
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Compilefailure on MAC and Linux for build 57.0.2987.42 on Official Desktop builder.

Project Member Reported by ranjitkan@chromium.org, Feb 10 2017

Issue description

Build URL:
==========
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1494
https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/1496

Log URL:
========
https://uberchromegw.corp.google.com/i/official.desktop/builders/mac64/builds/1494/steps/compile/logs/stdio
https://uberchromegw.corp.google.com/i/official.desktop/builders/precise64/builds/1496/steps/compile/logs/stdio

Error from the Log:
===================
FAILED: obj/content/browser/browser/touch_event_queue.o 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/content/browser/browser/touch_event_queue.o.d -DENABLE_SCREEN_CAPTURE=1 -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DUSE_EXTERNAL_POPUP_MENU=1 -DUSE_PROPRIETARY_CODECS -DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING_DB_LOCAL -DOFFICIAL_BUILD -DGOOGLE_CHROME_BUILD -DENABLE_MEDIA_ROUTER=1 -DCR_CLANG_REVISION=289944-2 -DCR_XCODE_VERSION=0511 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2 -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -DCONTENT_IMPLEMENTATION -DV8_USE_EXTERNAL_STARTUP_DATA -DLEVELDB_PLATFORM_CHROMIUM=1 -DSK_IGNORE_DW_GRAY_FIX -DSK_IGNORE_LINEONLY_AA_CONVEX_PATH_OPTS -DSK_SUPPORT_GPU=1 -DSK_BUILD_FOR_MAC -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD -DMESA_EGL_NO_X11_HEADERS -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX -DWEBRTC_MAC -DXML_STATIC -DSSL_USE_OPENSSL -DHAVE_OPENSSL_SSL_H -DFEATURE_ENABLE_SSL -DNO_MAIN_THREAD_WRAPPING -DFLAC__NO_DLL -I../.. -Igen -I../../third_party/khronos -I../../gpu -I../../third_party/leveldatabase -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase/src/include -I../../skia/config -I../../skia/ext -I../../third_party/skia/include/c -I../../third_party/skia/include/config -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/images -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pdf -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/gpu -I../../third_party/skia/src/gpu -I../../third_party/skia/src/sksl -I../../third_party/ced/src -I../../third_party/icu/source/common -I../../third_party/icu/source/i18n -I../../third_party/protobuf/src -Igen/protoc_out -I../../third_party/protobuf/src -Igen/blink -I../../third_party/libwebm/source -I../../third_party/boringssl/src/include -Igen -I../../third_party/WebKit -Igen/third_party/WebKit -I../../v8/include -Igen/v8/include -I../../v8/include -Igen/v8/include -I../../third_party/mesa/src/include -I../../third_party/angle/src/common/third_party/numerics -Igen/angle -I../../third_party/libyuv/include -I../../third_party/re2/src -I../../third_party/zlib -Igen/ui/resources -Igen/ui/resources -Igen/content/browser/tracing -I../../third_party/webrtc_overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc_overrides -I../../third_party -I../../third_party/expat/files/lib -fno-strict-aliasing -fstack-protector -fcolor-diagnostics -arch x86_64 -Wall -Werror -Wextra -Wpartial-availability -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O2 -gdwarf-2 -fno-standalone-debug -isysroot /Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk -mmacosx-version-min=10.9 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -Wtautological-overlap-compare -Wexit-time-destructors -fno-threadsafe-statics -fvisibility-inlines-hidden -std=c++11 -stdlib=libc++ -fno-rtti -fno-exceptions -c ../../content/browser/renderer_host/input/touch_event_queue.cc -o obj/content/browser/browser/touch_event_queue.o
../../content/browser/renderer_host/input/touch_event_queue.cc:33:14: error: unused variable 'kMaxConceivablePlatformSlopRegionLengthDipsSquared' [-Werror,-Wunused-const-variable]
const double kMaxConceivablePlatformSlopRegionLengthDipsSquared = 60. * 60.;

Change Log: https://chromium.googlesource.com/chromium/src/+log/57.0.2987.41..57.0.2987.42?pretty=fuller&n=10000

Suspecting the below change could be a possible culprit.

https://chromium.googlesource.com/chromium/src/+/3a7825120516721b47e220d4075945834e78401f

@ lanwei: Assigning to you, request you to please take a look into it. Please help us to find an owner if not with respect to your change.

Adding Release block label, please undo if not the case.

Thanks.!

 
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 10 2017

Labels: merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1094e7d4cb256d1f57f5bb49e34577b72c727cf4

commit 1094e7d4cb256d1f57f5bb49e34577b72c727cf4
Author: lanwei <lanwei@chromium.org>
Date: Fri Feb 10 03:14:52 2017

Fix compile failure on Mac and Linux for build 57.0.2987.42

There is unused variable kMaxConceivablePlatformSlopRegionLengthDipsSquared
in touch_event_queue.cc. Now remove it.

BUG=690758,  690759 

Review-Url: https://codereview.chromium.org/2683283003 .
Cr-Commit-Position: refs/branch-heads/2987@{#427}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/1094e7d4cb256d1f57f5bb49e34577b72c727cf4/content/browser/renderer_host/input/touch_event_queue.cc

Comment 2 by gov...@chromium.org, Feb 10 2017

Thank you lanwei@ for fixing the bug.

I re-triggered new M57 offical build #57.0.2987.43 with this fix in. 
ranjitkan@, please keep an eye on newly triggered build. Thank you.

Comment 3 by gov...@chromium.org, Feb 10 2017

Mergedinto: 690758
Status: Duplicate (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d3a63da18fc6ce031db92e61c6adbdc828fd9a6f

commit d3a63da18fc6ce031db92e61c6adbdc828fd9a6f
Author: mustaq <mustaq@chromium.org>
Date: Tue Feb 14 23:35:49 2017

Revert of Fix compile failure on Mac and Linux for build 57.0.2987.42 (patchset #1 id:1 of https://codereview.chromium.org/2683283003/ )

Reason for revert:
Compile failure from previous revert: crbug.com/692248

Original issue's description:
> Fix compile failure on Mac and Linux for build 57.0.2987.42
>
> There is unused variable kMaxConceivablePlatformSlopRegionLengthDipsSquared
> in touch_event_queue.cc. Now remove it.
>
> BUG=690758,  690759 
>
> Review-Url: https://codereview.chromium.org/2683283003 .
> Cr-Commit-Position: refs/branch-heads/2987@{#427}
> Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
> Committed: https://chromium.googlesource.com/chromium/src/+/1094e7d4cb256d1f57f5bb49e34577b72c727cf4

TBR=lanwei@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=692248
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2695923005
Cr-Commit-Position: refs/branch-heads/2987@{#513}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/d3a63da18fc6ce031db92e61c6adbdc828fd9a6f/content/browser/renderer_host/input/touch_event_queue.cc

Comment 5 by ananthak@google.com, Apr 27 2017

Components: Build

Sign in to add a comment