Thanks for catching! I'll take a look.

+some files.app folks

It seems camera app shows read-only volumes in "save file as" dialog; including zip archive and media views. Maybe we should filter out those volumes since users can't save to those volumes anyway.

Deleted: Screenshot 2017-02-10 at 1.17.22 PM.png 163 KB

	Screenshot 2017-02-10 at 1.17.22 PM.png 163 KB View Download

Weifang,
Can we hide all read-only volumes (including media view, zip archive, write-protected SD, etc...) in save dialog?

I see Mac OS Finder shows read-only volumes even in save dialog. But I'm not sure if it is beneficial for users.

That makes sense to me. I agree we should only allow for navigation to write-able directories in the Save dialog.

Question - I noticed that when I try to save an image from the Chrome browser, only Drive and Downloads are available to Save to. My Dropbox directory (which should be writeable) is not included. Is there a reason for this difference?

Oh, sorry. I forgot the current behavior.
In save dialog, we show volumes which support native paths (Downloads, SD, etc...) and Google Drive.
Context: see https://bugs.chromium.org/p/chromium/issues/detail?id=581984#c7

We already hide FSP volumes in save dialog, so hiding media view in the same manner should be sufficient to fix this issue, I think.

Ah, thanks for the additional context. Let's move forward with this approach. Can you assign to the right person to work on this?

Maybe nya@ can handle this if you have cycles?
Please reassign this back to me or yamaguchi@ if it's going to involve design changes in Files app.

Sure, I'll take a look.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271

commit 59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271
Author: nya <nya@chromium.org>
Date: Tue Feb 14 04:35:21 2017

Hide read-only volumes in "Save As" dialogs.

BUG= chromium:690757 
TEST=Save as dialog in Camera app does not show zip/media view volumes.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2695613002
Cr-Commit-Position: refs/heads/master@{#450247}

[modify] https://crrev.com/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271/ui/file_manager/audio_player/js/audio_player.js
[modify] https://crrev.com/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271/ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
[modify] https://crrev.com/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271/ui/file_manager/video_player/js/video_player.js

Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/762d9204793e5906a8c94fbf27ba97d808b3808c

commit 762d9204793e5906a8c94fbf27ba97d808b3808c
Author: Shuhei Takahashi <nya@chromium.org>
Date: Wed Feb 15 05:56:26 2017

Hide read-only volumes in "Save As" dialogs.

BUG= chromium:690757 
TEST=Save as dialog in Camera app does not show zip/media view volumes.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2695613002
Cr-Commit-Position: refs/heads/master@{#450247}
(cherry picked from commit 59a09c0b0ce14dd00ad1cfca4ecc37ce8f27b271)

Review-Url: https://codereview.chromium.org/2699583002 .
Cr-Commit-Position: refs/branch-heads/2987@{#518}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/762d9204793e5906a8c94fbf27ba97d808b3808c/ui/file_manager/audio_player/js/audio_player.js
[modify] https://crrev.com/762d9204793e5906a8c94fbf27ba97d808b3808c/ui/file_manager/file_manager/foreground/js/file_manager.js
[modify] https://crrev.com/762d9204793e5906a8c94fbf27ba97d808b3808c/ui/file_manager/file_manager/foreground/js/volume_manager_wrapper.js
[modify] https://crrev.com/762d9204793e5906a8c94fbf27ba97d808b3808c/ui/file_manager/gallery/js/gallery.js
[modify] https://crrev.com/762d9204793e5906a8c94fbf27ba97d808b3808c/ui/file_manager/video_player/js/video_player.js

Issue still exists on 9202.64.0 / 57.0.2987.146 and TOT

Reopening the bug.

 Issue 709382  has been merged into this issue.

Hmm, strange. I'm taking a look.

It seems the problem about Camera app was not fixed by comment 13. My commit fixed the case where a save-as dialog was requested, but Camera app uses an open-directory dialog [1]. Since Chrome File System API [2] does not provide a way to express whether the chosen directory will be used for writing or reading, we can't decide whether to show read only file systems like media views.

To properly fix the camera app case we need to extend Chrome API [2] to allow apps to specify whether the opened directory is used for reading or writing. Files app team and PMs, WDYT?

<off-topic>
Then it is mysterious how I verified the commit in comment 13... I remember I surely verified with Camera app. There might be another bug. Actually today while I'm testing media views for this bug, I found an issue that media views are not shown even if ARC is enabled. Maybe I encountered similar issue when I verified the fix.
</off-topic>

[1] https://chromium.googlesource.com/apps/camera/+/master/src/js/views/gallery_base.js#152
[2] https://developer.chrome.com/apps/fileSystem#method-chooseEntry

We used to have a save dialog but around IIRC it was changed a year ago or so. The open dialog is confusing so as a workaround we were planning to show a "Save" dialog for single elements, and "Open" for more than one selected. Then we would fix the issue at least when users select only one picture.


Are the media view volumes read only? If so, then per documentation we shouldn't be showing them in the picker if the app has the filesystem writable permission. However, it feels that the API is not designed well. I can think of plenty of cases where this wouldn't work.


So, personally +1 for extending this API if it's causing a lot of user pain. Otherwise we could show a dialog in Camera app that the selected destination is read only and ask to choose another.

Media view volumes are read-only.

Yup, extending the API is a "proper" fix but it will be non-trivial work (including updating API spec). Maybe we can handle the case in Camera app. Actually no error is shown when the user selects media view volumes as destination, which is bad.

Similar complaints in issue 694113

Releasing this bug since I'm busy for other tasks. Please feel free to grab.

<files-triage>

Weifang to find owner for this.

issue 816363 makes this bug obsolete.