New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690753 link

Starred by 1 user
Status: Fixed
Owner:
carlosk@chromium.org
Closed: Feb 2017
Cc:
klo...@chromium.org
█ dim...@chromium.org
█ talo@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug

Blocking:
issue 678367



Sign in to add a comment

Last_n: implement limitations/disabling of last_n for Svelte devices

Project Member Reported by carlosk@chromium.org, Feb 10 2017 
Svelte devices have much stricter requirements for Chrome: no extra renderer process and as-low-as-possible memory usage. We have to decide on limiting or disabling last_n in this cases and implement the decision.
Project Member

Comment 1 by bugdroid1@chromium.org, Feb 17 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec269885f32e22ded6c3d0531038a18782e5c438

commit ec269885f32e22ded6c3d0531038a18782e5c438
Author: carlosk <carlosk@chromium.org>
Date: Fri Feb 17 04:47:34 2017

Last_n: disable on Svelte devices.

This CL disables last_n on Svelte devices (less than 512 MB of RAM) as
suggested during discussions. It also adds a test that checks that it
actually does that but still allows user triggered snapshots.

BUG= 690753 

Review-Url: https://codereview.chromium.org/2705453003
Cr-Commit-Position: refs/heads/master@{#451219}

[modify] https://crrev.com/ec269885f32e22ded6c3d0531038a18782e5c438/chrome/browser/android/offline_pages/recent_tab_helper.cc
[modify] https://crrev.com/ec269885f32e22ded6c3d0531038a18782e5c438/chrome/browser/android/offline_pages/recent_tab_helper.h
[modify] https://crrev.com/ec269885f32e22ded6c3d0531038a18782e5c438/chrome/browser/android/offline_pages/recent_tab_helper_unittest.cc

Comment 2 by carlosk@chromium.org, Feb 17 2017

Cc: talo@chromium.org klo...@chromium.org
Status: Fixed (was: Assigned)
CC-ing talo@ and klobag@ FYI.

The changed landed in #1 fully disables last_n in Svelte devices. In the future we might try to run experiments to assess the actual impact of this feature on these devices but for now this is done.
►

Sign in to add a comment