New issue
Advanced search Search tips
Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment
link

Issue 690734: Update calls to mig to take an explicit isysroot.

Reported by erikc...@chromium.org, Feb 10 2017 Project Member

Issue description

I recently updated my machine to macOS 10.12.3. Suddenly mig stopped working. Typical error looks like:
"""
/Applications/Xcode7.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/usr/include/mach/mach_exc.defs:69:10: fatal error: 
      'mach/std_types.defs' file not found
#include <mach/std_types.defs>
"""

Adding an explicit isysroot argument to mig fixes this issue. I don't think this is a 10.12.3 issue, since other people are compiling fine.
 

Comment 1 by mark@chromium.org, Feb 10 2017

Cc: mark@chromium.org
Labels: OS-Mac
This may be a presence/absence of Xcode command-line tools thing. But also, why aren’t you on Xcode 8.2.1?

Comment 2 by erikc...@chromium.org, Feb 10 2017

This error occurs with Xcode 5.1, 6.2, 7.3.1, and 8.2. AFAICT, it is not directly related to DEVELOPER_DIR or xcode-select

Comment 4 by mark@chromium.org, Feb 11 2017

Status: Fixed (was: Untriaged)
Bugdroid’s asleep at the wheel, but this landed in Crashpad too as https://crrev.com/c1b305244aba9c8ea3265cadba9ecaca0dbb9461.

Comment 5 by bugdroid1@chromium.org, Feb 21 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/native_client/src/native_client.git/+/81142aef3ec03dbc554e1cb0e22e4243e8aa69af

commit 81142aef3ec03dbc554e1cb0e22e4243e8aa69af
Author: Erik Chen <erikchen@chromium.org>
Date: Tue Feb 21 21:31:44 2017

Update run_mig.py to take an optional --sdk argument.

BUG= chromium:690734 
NOTRY=true

Change-Id: I6e02fb029fe4591c0e30d6bcade57946da111637
Reviewed-on: https://chromium-review.googlesource.com/441367
Commit-Queue: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>

[modify] https://crrev.com/81142aef3ec03dbc554e1cb0e22e4243e8aa69af/src/trusted/service_runtime/BUILD.gn
[modify] https://crrev.com/81142aef3ec03dbc554e1cb0e22e4243e8aa69af/src/trusted/service_runtime/osx/run_mig.py

Comment 6 by bugdroid1@chromium.org, Feb 22 2017

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9b211782c44c33f76afede6c2eecfdd11ca0555

commit c9b211782c44c33f76afede6c2eecfdd11ca0555
Author: nacl-deps-roller <nacl-deps-roller@chromium.org>
Date: Wed Feb 22 21:29:21 2017

Roll src/native_client/ ee10b35a4..81142aef3 (1 commit).

https://chromium.googlesource.com/native_client/src/native_client.git/+log/ee10b35a44f8..81142aef3ec0

$ git log ee10b35a4..81142aef3 --date=short --no-merges --format='%ad %ae %s'
2017-02-15 erikchen Update run_mig.py to take an optional --sdk argument.

Created with:
  roll-dep src/native_client
BUG= 690734 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_nacl_sdk_build
TBR=mseaborn@chromium.org

Review-Url: https://codereview.chromium.org/2709813005
Cr-Commit-Position: refs/heads/master@{#452210}

[modify] https://crrev.com/c9b211782c44c33f76afede6c2eecfdd11ca0555/DEPS

Sign in to add a comment