New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690725 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Mar 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 621719



Sign in to add a comment

New OOBE final UI fixes

Project Member Reported by zalcorn@chromium.org, Feb 10 2017

Issue description

General
 - Status bar is not greyed out.
 - Corner radius of the modal should be 4dp
 - The underline of drop down expands when it's tapped. It should be the same length.
 - Scrollbar looks too big
 - Dropdown arrow is too big (refer to chrome settings)
 - Separator of the options are too dark (accessibility, languages), should be #000 6%.
 - 10dp space left of language and keyboard, accessibility options
 - Switches need to be smaller and in #4285F4 when selected (the color looks purple now)
 - Button animation is cut off in the middle - accelerate the fill animation to complete before page changes.

Welcome Page
 - Welcome should be Roboto light instead of regular and should be #000 87%

ToS
 - Flash appears between network and ToS
 - Box border needs styling.
 - Checkbox is too big, needs to be aligned with text.
 - Clicking anywhere on text next to the checkbox should deselect/select the checkbox.

 
Notes from zalcorn / alemate sync:
- Dropdown arrow is the same implementation as in settings
- Underline is the same implementation as settings
- Button animation should be 2X as fast
- Scrollbar that is too big is on ToS
- alemate to look into flash between network and ToS, box border style, colors/fonts/sizes.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f08225136b6ad80d5ac4a86b2919d8b998f2fc66

commit f08225136b6ad80d5ac4a86b2919d8b998f2fc66
Author: jdufault <jdufault@chromium.org>
Date: Thu Feb 16 18:48:44 2017

cros: md-oobe UI tweaks.

Address first two items on bug:
 - Status bar is not greyed out.
 - Corner radius of the modal should be 4dp

BUG= 690725 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2695283004
Cr-Commit-Position: refs/heads/master@{#451026}

[modify] https://crrev.com/f08225136b6ad80d5ac4a86b2919d8b998f2fc66/chrome/browser/resources/chromeos/login/oobe_dialog_host.css
[modify] https://crrev.com/f08225136b6ad80d5ac4a86b2919d8b998f2fc66/chrome/browser/resources/chromeos/login/screen_container.html

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/841b84cb8f7eeb783b22af63a2c9f317d5b24691

commit 841b84cb8f7eeb783b22af63a2c9f317d5b24691
Author: alemate <alemate@chromium.org>
Date: Thu Feb 23 00:16:33 2017

grit: add support for inlining img srcset

This CL adds support for inlining srcset attributes of img tags.

R=thakis@chromium.org

BUG= 690725 

Review-Url: https://codereview.chromium.org/2710933002
Cr-Commit-Position: refs/heads/master@{#452297}

[modify] https://crrev.com/841b84cb8f7eeb783b22af63a2c9f317d5b24691/tools/grit/grit/format/html_inline.py
[modify] https://crrev.com/841b84cb8f7eeb783b22af63a2c9f317d5b24691/tools/grit/grit/format/html_inline_unittest.py

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7322bbb0a42cfad6bf24e3bb157cb692381cda9f

commit 7322bbb0a42cfad6bf24e3bb157cb692381cda9f
Author: alemate <alemate@chromium.org>
Date: Thu Feb 23 10:08:58 2017

ChromeOS OOBE: Update Welcome screen colors after UI review.

BUG= 690725 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2717443002
Cr-Commit-Position: refs/heads/master@{#452447}

[modify] https://crrev.com/7322bbb0a42cfad6bf24e3bb157cb692381cda9f/chrome/browser/resources/chromeos/login/oobe_a11y_option.html
[modify] https://crrev.com/7322bbb0a42cfad6bf24e3bb157cb692381cda9f/chrome/browser/resources/chromeos/login/oobe_welcome.css

Project Member

Comment 6 by bugdroid1@chromium.org, Mar 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7e2c6819395a5185f0f90d6cff8f3a47c444ce86

commit 7e2c6819395a5185f0f90d6cff8f3a47c444ce86
Author: alemate <alemate@chromium.org>
Date: Wed Mar 01 22:59:04 2017

ChromeOS OOBE: More accessibility fixes.

This CL updates the following code:
1) Ensures aria-labels are DOM-attributes.
2) Updates some labels for OOBE.
3) Fixes focusing and input on EULA screen.

BUG= 690725 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2718133004
Cr-Commit-Position: refs/heads/master@{#454082}

[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/app/chromeos_strings.grdp
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/gaia_buttons.html
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_a11y_option.js
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_buttons.html
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_buttons.js
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_eula.css
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_eula.html
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_i18n_dropdown.js
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_welcome.html
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_welcome.js
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html
[modify] https://crrev.com/7e2c6819395a5185f0f90d6cff8f3a47c444ce86/chrome/browser/ui/webui/chromeos/login/network_screen_handler.cc

Project Member

Comment 7 by bugdroid1@chromium.org, Mar 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c8103f16188658d2dbf45d14a8a2a3a8467ba44

commit 3c8103f16188658d2dbf45d14a8a2a3a8467ba44
Author: alemate <alemate@chromium.org>
Date: Fri Mar 03 02:44:24 2017

Added aria-live="polite" to update screen

BUG= 690725 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2730823002
Cr-Commit-Position: refs/heads/master@{#454476}

[modify] https://crrev.com/3c8103f16188658d2dbf45d14a8a2a3a8467ba44/chrome/browser/resources/chromeos/login/oobe_update.html

Comment 8 by st...@chromium.org, Mar 3 2017

Cc: r...@chromium.org

Comment 9 by st...@chromium.org, Mar 3 2017

Cc: -st...@chromium.org
Labels: Merge-Request-58
Status: Fixed (was: Assigned)
Requesting merge for https://codereview.chromium.org/2730823002
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 4 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: There is .grd file changes and we are only 51 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), bhthompson@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Merge-Request: https://codereview.chromium.org/2730823002 does not have any strings!
Status: Verified (was: Fixed)
Labels: -Merge-Review-58
No need to update M58.

Sign in to add a comment