Add UMA for key request generation time |
||
Issue descriptionGenerating key request may take a lot of work in the CDM. We should add a UMA to monitor the time spent by the CDM to generate the key request. Note that the real key request is in a session message sent asynchronously, so it's a little bit hard to keep track of it. However, the spec does require that the GenerateRequest() promise be resolved and returned after the key request is generated and the message containing the request queued in a task [1]. So we could just record the time from GenerateRequest() is called, to when the promise is resolved. We could also only report this for the first session created. [1] https://w3c.github.io/encrypted-media/#dom-mediakeysession-generaterequest
,
Feb 11 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6445a816eea59b22caa418e00be12f1ccf9be21c commit 6445a816eea59b22caa418e00be12f1ccf9be21c Author: xhwang <xhwang@chromium.org> Date: Sat Feb 11 09:36:43 2017 media: Add UMA to record time to GenerateRequest and LoadSession This could help us monitor the performance of these two operations on various key systems. In the future, we could also report time spent on other operations like UpdateSession() if needed. BUG= 690722 TEST=Manually tested and saw Media.EME.Widevine.TimeTo.GenerateRequest in about://histograms Review-Url: https://codereview.chromium.org/2691673002 Cr-Commit-Position: refs/heads/master@{#449853} [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/media/blink/cdm_result_promise_helper.h [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/media/blink/cdm_session_adapter.cc [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/media/blink/cdm_session_adapter.h [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/media/blink/new_session_cdm_result_promise.cc [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/media/blink/new_session_cdm_result_promise.h [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/media/blink/webcontentdecryptionmodulesession_impl.cc [modify] https://crrev.com/6445a816eea59b22caa418e00be12f1ccf9be21c/tools/metrics/histograms/histograms.xml
,
Feb 11 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by xhw...@chromium.org
, Feb 10 2017Owner: xhw...@chromium.org
Status: Assigned (was: Available)