New issue
Advanced search Search tips

Issue 690711 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature


Show other hotlists

Hotlists containing this issue:
EnamelAndFriendsFixIt


Sign in to add a comment

Display a warning in the security panel if the certificate is expiring in the next 24/48/72 hours

Project Member Reported by mea...@chromium.org, Feb 9 2017

Issue description

As we discussed, it would be nice to give a warning if the cert is about to expire shortly. This hopefully won't be too out of place, since we already do similar things like warn about upcoming deprecations in the security panel.
 
Summary: Display a warning in the security panel if the certificate is expiring in the next 24/48/72 hours (was: Display a warning if the certificate is expiring in the next 24/48/72 hours in security panel)

Comment 2 by est...@chromium.org, Feb 10 2017

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows
Status: Available (was: Untriaged)

Comment 3 by est...@chromium.org, Mar 24 2017

Labels: -Type-Bug Type-Feature

Comment 4 by est...@chromium.org, Nov 10 2017

Labels: Hotlist-EnamelAndFriendsFixIt
Components: -Platform>DevTools>Security Security
Status: Untriaged (was: Available)
This is outside of the DevTools component, one can use console API in Blink or content to report it.
Cc: -lgar...@chromium.org
Owner: mea...@chromium.org
Status: Assigned (was: Untriaged)
meacer@, could you help re-triage this issue since you're the original reporter? Thanks!

Comment 7 by cthomp@chromium.org, Dec 20 2017

I think two reasonable places to put this would be

1) DocumentLoader::DidCommitNavigation in blink (where the Legacy Symantec Cert console warning is)
2) c/b/ssl/SecurityStateTabHelper::DidFinishNavigation

I made a quick CL for (2) at https://crrev.com/c/837029 but haven't written any tests for it yet. I quickly found a soon-to-expire cert [1] via Censys [2], and checked that the console warning displays as desired.

No worries if we decide to not add this now, but I do think it would be a useful reminder to reduce unintentionally expired certificates.

[1] https://www.marekashley.com
[2] https://censys.io/certificates?q=parsed.validity.end%3A+2017-12-21

Comment 8 by cthomp@chromium.org, Dec 20 2017

(Specifically, this takes the very simple route of generating a console warning message rather than adding a bullet to the security panel.)

Comment 9 by cthomp@chromium.org, Dec 20 2017

Cc: cthomp@chromium.org
Cc: -cthomp@chromium.org mea...@chromium.org est...@chromium.org
Owner: cthomp@chromium.org
Status: Started (was: Assigned)
Do we have any strong opinions about how far-out the warning should happen? 48 hours seems like a good base to go with if not.

After discussing with estark@ I changed the CL to display in the Security Panel instead. Since it's no longer potentially clogging the console output, would warning sooner be better?

Comment 11 by meacer@google.com, Dec 22 2017

Thanks for taking this Chris. I'd love to have a week of notice in advance, but perhaps that won't be effective as it's too far in the future. So 48 hours SGTM as a starting point.
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/96fba2ff8246938a93a8da7e69b25103f3381762

commit 96fba2ff8246938a93a8da7e69b25103f3381762
Author: Christopher Thompson <cthomp@chromium.org>
Date: Tue Jan 09 17:13:15 2018

Add security panel bullet for expiring SSL certs

This adds a Security Panel info bullet for sites that have an SSL
certificate which is expiring in soon (<48 hours from now). This may
help some developers notice expiring certificates that they had
otherwise forgotten about.

Bug:  690711 
Change-Id: I7af4e2bd70bbadf73c93c4bb1e379df260d26414
Reviewed-on: https://chromium-review.googlesource.com/837029
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: David Benjamin <davidben@chromium.org>
Commit-Queue: Christopher Thompson <cthomp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528023}
[modify] https://crrev.com/96fba2ff8246938a93a8da7e69b25103f3381762/components/security_state/content/DEPS
[modify] https://crrev.com/96fba2ff8246938a93a8da7e69b25103f3381762/components/security_state/content/content_utils.cc
[modify] https://crrev.com/96fba2ff8246938a93a8da7e69b25103f3381762/components/security_state/content/content_utils_unittest.cc
[modify] https://crrev.com/96fba2ff8246938a93a8da7e69b25103f3381762/components/security_state_strings.grdp

Status: Fixed (was: Started)

Sign in to add a comment