Issue metadata
Sign in to add a comment
|
No Code-Review +1 button shows up if I'm a reviewer |
||||||||||||||||||
Issue descriptionOn https://chromium-review.googlesource.com/c/436324/, I'm a reviewer, but when I go to lgtm (or +1?) the CL, no buttons show up. It looks like this: ----- Code-Review Commit-Queue | 0 | | +1 | ----- This might also be due to me not being a committer in infra/infra?
,
Feb 9 2017
In reitveld we could have anyone LGTM a patch (committer or otherwise). The +1 is suppose to be equivalent to LGTM, then non-committers need to be able to +1 a patch.
,
Feb 9 2017
Let me send this over to chrome-infra.
,
Feb 9 2017
,
Feb 10 2017
In rietveld anyone could *believe* they were LGTM'ing the patch, only to have their approval rejected by the CQ when it determined that they weren't in the correct committers list. Gerrit just makes that check happen one step sooner. That said, we definitely need better messaging around this. When someone isn't offered buttons, the UI should say why not. At the very least, it should say "insufficient permissions". If possible, it should say which groups they would need to be a member of in order to have sufficient permissions. I'm going to dupe this into another bug where we're talking about similar improvements to the UI around label buttons. |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by logan@google.com
, Feb 8 2017