Issue metadata
Sign in to add a comment
|
89.4% regression in blink_perf.bindings at 448895:448938 |
||||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Feb 9 2017
Started bisect job https://chromeperf.appspot.com/buildbucket_job_status/8988096575207515520
,
Feb 10 2017
=== Auto-CCing suspected CL author tkent@chromium.org === Hi tkent@chromium.org, the bisect results pointed to your CL, please take a look at the results. === BISECT JOB RESULTS === Perf regression found with culprit Suspected Commit Author : tkent Commit : 1c12127b721f833f37b81553e19b8eb0392da651 Date : Wed Feb 08 07:22:24 2017 Subject: DOM: Remove standard-violating optimizations in appendChild, insertBefore, and replaceChild. Bisect Details Configuration: android_webview_nexus6_aosp_perf_bisect Benchmark : blink_perf.bindings Metric : insert-before/insert-before Change : 90.09% | 64.8770524657 -> 6.42718267782 Revision Result N chromium@448894 64.8771 +- 2.97473 6 good chromium@448916 61.4748 +- 1.58445 6 good chromium@448927 64.0892 +- 2.65885 6 good chromium@448928 6.51989 +- 0.228953 6 bad <-- chromium@448929 6.67086 +- 0.121008 6 bad chromium@448930 6.6469 +- 0.30057 5 bad chromium@448933 6.69927 +- 0.114466 6 bad chromium@448938 6.42718 +- 0.111561 6 bad To Run This Test src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings Debug Info https://chromeperf.appspot.com/buildbucket_job_status/8988096575207515520 Is this bisect wrong? https://chromeperf.appspot.com/bad_bisect?try_job_id=5874169109020672 | O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq | X | for more information addressing perf regression bugs. For feedback, | / \ | file a bug with component Speed>Bisection. Thank you!
,
Feb 10 2017
Assuming this regression is expected. Close as WontFix?
,
Feb 10 2017
It does look expected, but cc-ing benchmark owners to check.
,
Feb 11 2017
Given that the new behavior matches Firefox and Safari, I think we should land the CL even though it causes a perf regression. Just to confirm: There 's no regression observed in Dromaeo and Speedometer, right?
,
Feb 13 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by briander...@chromium.org
, Feb 9 2017