New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690673 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

91.8% regression in blink_perf.bindings at 448895:448938

Project Member Reported by briander...@chromium.org, Feb 9 2017

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=690673

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDg6Ir_gwoM


Bot(s) for this bug's original alert(s):

android-webview-nexus6
Project Member

Comment 3 by 42576172...@developer.gserviceaccount.com, Feb 10 2017


=== BISECT JOB RESULTS ===
Perf regression found but unable to narrow commit range

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : blink_perf.bindings
  Metric       : append-child/append-child

Suspected Commit Range
  6 commits in range
  https://chromium.googlesource.com/chromium/src/+log/a79a95466df9d013721167cf2f0c8ba849214207..c3f9c94930b6c12bb70d352d772fe52d7ec92bb9


Revision             Result                   N
chromium@448894      86.2914 +- 0.906871      6      good
chromium@448916      82.4186 +- 1.67113       6      good
chromium@448927      88.6349 +- 1.22637       6      good
chromium@448933      7.20746 +- 0.171362      6      bad
chromium@448938      6.60993 +- 0.105923      6      bad

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests blink_perf.bindings

Debug Info
  https://chromeperf.appspot.com/buildbucket_job_status/8988096585483695216

Is this bisect wrong?
  https://chromeperf.appspot.com/bad_bisect?try_job_id=5873817626345472


| O O | Visit http://www.chromium.org/developers/speed-infra/perf-bug-faq
|  X  | for more information addressing perf regression bugs. For feedback,
| / \ | file a bug with component Speed>Bisection.  Thank you!
Owner: tkent@chromium.org
Status: Assigned (was: Untriaged)
Suspecting:
1c12127b DOM: Remove standard-violating optimizations in appendChild, insertBefore, and replaceChild.

Looks like this regression is expected. @tkent: Is the magnitude of the regression acceptable?

Comment 5 by tkent@chromium.org, Feb 13 2017

Cc: bashi@chromium.org yukishiino@chromium.org haraken@chromium.org tkent@chromium.org
 Issue 690674  has been merged into this issue.

Comment 6 by tkent@chromium.org, Feb 13 2017

Status: WontFix (was: Assigned)
Degration in some micro benchmarks are expected.
This is a binding test, and we know the degration was caused by non-binding change.  So we may close this.
However, I'm not sure if measuring DOM functions with side-effect is helpful to measure binding performance.


Sign in to add a comment