New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690669 link

Starred by 1 user
Status: Fixed
Owner:
pnoland@chromium.org
Closed: Feb 2017
Cc:
pav...@chromium.org
mastiz@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

[Sync] passphrase crash

Project Member Reported by s...@chromium.org, Feb 9 2017 
Steps I took before the crash:
1. Build developer copy of chromium
2. > rm -rf ~/.config/chromium
3. alt tab away
4. modify gn args
5. rebuild
6. crash on background chrome

The rebuild might be a red herring. Not sure this is worth investigating unless we see more or repeated crashes.

[146927:146927:0209/143703.959155:WARNING:CONSOLE(2299)] "Unrecognized message from GAIA: showConfirmCancel", source: chrome://chrome-signin/gaia_auth_host.js (2299)
[146927:146927:0209/143706.773952:WARNING:CONSOLE(2299)] "Unrecognized message from GAIA: clearOldAttempts", source: chrome://chrome-signin/gaia_auth_host.js (2299)
[1:1:0209/143707.652379:ERROR:KeyboardEventManager.cpp(427)] Not implemented reached in static bool blink::KeyboardEventManager::currentCapsLockState()
[146927:146927:0209/143708.024173:WARNING:CONSOLE(2299)] "Unrecognized message from GAIA: showConfirmCancel", source: chrome://chrome-signin/gaia_auth_host.js (2299)
[146927:146927:0209/143710.566183:INFO:CONSOLE(0)] "Error in event handler for (unknown): TypeError: Cannot read property 'send' of null
    at BackgroundBridge.onAPICall_ (chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/background.js:440:22)
    at Channel.invokeMessageCallbacks_ (chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/channel.js:85:42)
    at Channel.onMessage_ (chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/channel.js:110:12)", source: chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik/_generated_background_page.html (0)
[146927:147181:0209/143711.272529:WARNING:server_connection_manager.cc(269)] ServerConnectionManager forcing SYNC_AUTH_ERROR
[146927:147181:0209/143711.272727:WARNING:syncer_proto_util.cc(338)] Error posting from syncer: Response Code (bogus on error): -1 Content-Length (bogus on error): -1 Server Status: SYNC_AUTH_ERROR
[146927:146927:0209/143712.772574:ERROR:CONSOLE(1)] "Uncaught ReferenceError: inline is not defined", source:  (1)
[146927:146927:0209/143713.834811:ERROR:selection_owner.cc(192)] SelectionClear
[146927:146927:0209/143717.112934:ERROR:data_type_manager_impl.cc(36)] Bookmarks cryptographer error was encountered: 
[146927:146927:0209/143717.112999:ERROR:data_type_manager_impl.cc(36)] Preferences cryptographer error was encountered: 
[146927:146927:0209/143717.113031:ERROR:data_type_manager_impl.cc(36)] Passwords cryptographer error was encountered: 
[146927:146927:0209/143717.113059:ERROR:data_type_manager_impl.cc(36)] Autofill Profiles cryptographer error was encountered: 
[146927:146927:0209/143717.113087:ERROR:data_type_manager_impl.cc(36)] Autofill cryptographer error was encountered: 
[146927:146927:0209/143717.113115:ERROR:data_type_manager_impl.cc(36)] Autofill Wallet Metadata cryptographer error was encountered: 
[146927:146927:0209/143717.113146:ERROR:data_type_manager_impl.cc(36)] Themes cryptographer error was encountered: 
[146927:146927:0209/143717.113187:ERROR:data_type_manager_impl.cc(36)] Typed URLs cryptographer error was encountered: 
[146927:146927:0209/143717.113220:ERROR:data_type_manager_impl.cc(36)] Extensions cryptographer error was encountered: 
[146927:146927:0209/143717.113250:ERROR:data_type_manager_impl.cc(36)] Search Engines cryptographer error was encountered: 
[146927:146927:0209/143717.113279:ERROR:data_type_manager_impl.cc(36)] Sessions cryptographer error was encountered: 
[146927:146927:0209/143717.113311:ERROR:data_type_manager_impl.cc(36)] Apps cryptographer error was encountered: 
[146927:146927:0209/143717.113340:ERROR:data_type_manager_impl.cc(36)] App settings cryptographer error was encountered: 
[146927:146927:0209/143717.113372:ERROR:data_type_manager_impl.cc(36)] Extension settings cryptographer error was encountered: 
[146927:146927:0209/143717.113402:ERROR:data_type_manager_impl.cc(36)] Dictionary cryptographer error was encountered: 
[146927:146927:0209/143717.113450:ERROR:data_type_manager_impl.cc(36)] Favicon Images cryptographer error was encountered: 
[146927:146927:0209/143717.113484:ERROR:data_type_manager_impl.cc(36)] Favicon Tracking cryptographer error was encountered: 
[1:1:0209/143717.501963:ERROR:render_process_impl.cc(208)] WebFrame LEAKED 1 TIMES
[146927:146927:0209/143717.537533:FATAL:profile_sync_service.cc(1210)] Check failed: crypto_->cached_passphrase().empty(). 
#0 0x7f825dac3aab base::debug::StackTrace::StackTrace()
#1 0x7f825dac20ec base::debug::StackTrace::StackTrace()
#2 0x7f825db2ce5f logging::LogMessage::~LogMessage()
#3 0x7f8261c2f617 browser_sync::ProfileSyncService::OnConfigureDone()
#4 0x7f8263adffc8 syncer::DataTypeManagerImpl::NotifyDone()
#5 0x7f8263ae2029 syncer::DataTypeManagerImpl::OnModelAssociationDone()
#6 0x7f8263b043b2 syncer::ModelAssociationManager::ModelAssociationDone()
#7 0x7f8263b04bfb syncer::ModelAssociationManager::TypeStartCallback()
#8 0x7f8263b06a93 _ZN4base8internal13FunctorTraitsIMN6syncer23ModelAssociationManagerEFvNS2_9ModelTypeENS_9TimeTicksENS2_18DataTypeController15ConfigureResultERKNS2_15SyncMergeResultESA_EvE6InvokeIRKNS_7WeakPtrIS3_EEJRKS4_RKS5_S7_SA_SA_EEEvSC_OT_DpOT0_
#9 0x7f8263b06930 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN6syncer23ModelAssociationManagerEFvNS4_9ModelTypeENS_9TimeTicksENS4_18DataTypeController15ConfigureResultERKNS4_15SyncMergeResultESC_ERKNS_7WeakPtrIS5_EEJRKS6_RKS7_S9_SC_SC_EEEvOT_OT0_DpOT1_
#10 0x7f8263b06844 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer23ModelAssociationManagerEFvNS3_9ModelTypeENS_9TimeTicksENS3_18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultESB_EJNS_7WeakPtrIS4_EES5_S6_EEEFvS8_SB_SB_EE7RunImplIRKSD_RKSt5tupleIJSF_S5_S6_EEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS8_SB_SB_
#11 0x7f8263b066e3 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer23ModelAssociationManagerEFvNS3_9ModelTypeENS_9TimeTicksENS3_18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultESB_EJNS_7WeakPtrIS4_EES5_S6_EEEFvS8_SB_SB_EE3RunEPNS0_13BindStateBaseEOS8_SB_SB_
#12 0x7f8260a8514f base::internal::RunMixin<>::Run()
#13 0x7f8260a822b1 syncer::AsyncDirectoryTypeController::StartDone()
#14 0x7f8260a85c0c _ZN4base8internal13FunctorTraitsIMN6syncer28AsyncDirectoryTypeControllerEFvNS2_18DataTypeController15ConfigureResultERKNS2_15SyncMergeResultES8_EvE6InvokeIRKNS_7WeakPtrIS3_EEJS5_S8_S8_EEEvSA_OT_DpOT0_
#15 0x7f8260a85b19 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIRKMN6syncer28AsyncDirectoryTypeControllerEFvNS4_18DataTypeController15ConfigureResultERKNS4_15SyncMergeResultESA_ERKNS_7WeakPtrIS5_EEJS7_SA_SA_EEEvOT_OT0_DpOT1_
#16 0x7f8260a85a61 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer28AsyncDirectoryTypeControllerEFvNS3_18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultES9_EJNS_7WeakPtrIS4_EEEEEFvS6_S9_S9_EE7RunImplIRKSB_RKSt5tupleIJSD_EEJLm0EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEEOS6_S9_S9_
#17 0x7f8260a85973 _ZN4base8internal7InvokerINS0_9BindStateIMN6syncer28AsyncDirectoryTypeControllerEFvNS3_18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultES9_EJNS_7WeakPtrIS4_EEEEEFvS6_S9_S9_EE3RunEPNS0_13BindStateBaseEOS6_S9_S9_
#18 0x7f8260a8514f base::internal::RunMixin<>::Run()
#19 0x7f8260a86c91 _ZN4base8internal13FunctorTraitsINS_8CallbackIFvN6syncer18DataTypeController15ConfigureResultERKNS3_15SyncMergeResultES8_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEvE6InvokeIRKSC_JRKS5_S8_S8_EEEvOT_DpOT0_
#20 0x7f8260a86aec _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIRKNS_8CallbackIFvN6syncer18DataTypeController15ConfigureResultERKNS5_15SyncMergeResultESA_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJRKS7_SA_SA_EEEvOT_DpOT0_
#21 0x7f8260a86a84 _ZN4base8internal7InvokerINS0_9BindStateINS_8CallbackIFvN6syncer18DataTypeController15ConfigureResultERKNS4_15SyncMergeResultES9_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJS6_S7_S7_EEEFvvEE7RunImplIRKSD_RKSt5tupleIJS6_S7_S7_EEJLm0ELm1ELm2EEEEvOT_OT0_NS_13IndexSequenceIJXspT1_EEEE
#22 0x7f8260a8695c _ZN4base8internal7InvokerINS0_9BindStateINS_8CallbackIFvN6syncer18DataTypeController15ConfigureResultERKNS4_15SyncMergeResultES9_ELNS0_8CopyModeE1ELNS0_10RepeatModeE1EEEJS6_S7_S7_EEEFvvEE3RunEPNS0_13BindStateBaseE
#23 0x7f825dac9831 _ZNO4base8internal8RunMixinINS_8CallbackIFvvELNS0_8CopyModeE0ELNS0_10RepeatModeE0EEEE3RunEv
#24 0x7f825dac9252 base::debug::TaskAnnotator::RunTask()
#25 0x7f825db55f4f base::MessageLoop::RunTask()
#26 0x7f825db561d4 base::MessageLoop::DeferOrRunPendingTask()
#27 0x7f825db564be base::MessageLoop::DoWork()
#28 0x7f825db6e436 base::MessagePumpGlib::Run()
#29 0x7f825db55af7 base::MessageLoop::RunHandler()
#30 0x7f825dc0459a base::RunLoop::Run()
#31 0x7f82603ddc2e ChromeBrowserMainParts::MainMessageLoopRun()
#32 0x7f8256e6a9a8 content::BrowserMainLoop::RunMainMessageLoopParts()
#33 0x7f8256e799c6 content::BrowserMainRunnerImpl::Run()
#34 0x7f8256e63dd8 content::BrowserMain()
#35 0x7f8258650266 content::RunNamedProcessTypeMain()
#36 0x7f82586526bc content::ContentMainRunnerImpl::Run()
#37 0x7f825864f3f2 content::ContentMain()
#38 0x7f825ebd026a ChromeMain
#39 0x7f825ebd0192 main
#40 0x7f8249c67f45 __libc_start_main
#41 0x7f825ebd0095 <unknown>

Comment 1 by s...@chromium.org, Feb 9 2017 

Never mind about the elaborate steps above. Clean checkout, tip of tree, debug or release. Start with a new user data dir, on confirming sync settings, this crash happens.

Comment 2 by s...@chromium.org, Feb 9 2017

Cc: pav...@chromium.org
Components: -Services
Labels: -Pri-3 OS-Linux Pri-2
Owner: pnoland@chromium.org
Status: Assigned (was: Untriaged)
Okay, only crashes if you're signing into an account with a passphrase. Still a significant bug. Assigning to current bug fixer.
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/202a5a81ed0c0929c55d28e44b822f5bbc194ade

commit 202a5a81ed0c0929c55d28e44b822f5bbc194ade
Author: pnoland <pnoland@chromium.org>
Date: Fri Feb 10 17:47:32 2017

[sync] Call ConsumeCachedPassphraseIfPossible after SetSyncEngine

ConsumeCachedPassphrase returns early without a sync engine. Set the
engine before asking to consume the passphrase so that the passphrase
will actually be cleared when we expect it to be.

R=skym@chromium.org

BUG= 690669 

Review-Url: https://codereview.chromium.org/2683203003
Cr-Commit-Position: refs/heads/master@{#449649}

[modify] https://crrev.com/202a5a81ed0c0929c55d28e44b822f5bbc194ade/components/browser_sync/profile_sync_service.cc
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/377e0fd43c46e071986ea50c16b223cc4a5d40aa

commit 377e0fd43c46e071986ea50c16b223cc4a5d40aa
Author: pnoland <pnoland@chromium.org>
Date: Fri Feb 10 20:57:46 2017

[sync] Adjust ProfileSyncServiceStartupTest to do more crypto

Make the password non-empty, and add a mock call to the
DataTypeManager so that the FirstTime test passes. This test
fails when the previous patch for this bug is reverted.

BUG= 690669 

R=skym@chromium.org

Review-Url: https://codereview.chromium.org/2687153003
Cr-Commit-Position: refs/heads/master@{#449730}

[modify] https://crrev.com/377e0fd43c46e071986ea50c16b223cc4a5d40aa/components/browser_sync/profile_sync_service_startup_unittest.cc

Comment 5 by pnoland@chromium.org, Feb 13 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment