New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690663 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

Pixel_OffscreenCanvas2DResizeOnWorker flaky on Win10 Intel HD 530

Project Member Reported by ynovikov@chromium.org, Feb 9 2017

Issue description

For example:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20530%29/builds/173/steps/pixel_test/logs/stdio

(INFO) 2017-02-09 10:18:51,926 cloud_storage._GetLocked:332  Downloading gs://chromium-gpu-archive/reference-images/Pixel_OffscreenCanvas2DResizeOnWorker_v2_win_8086_1912_msaa.png to c:\b\c\b\win10_release__intel_hd_530_\itv0tfgo\tmpstqc_7.png
(INFO) 2017-02-09 10:18:53,453 cloud_storage.Insert:370  Uploading c:\b\c\b\win10_release__intel_hd_530_\itv0tfgo\tmpxru_ne.png to gs://chromium-browser-gpu-tests/runs/58067513307e4ab9d0bd473670cf3fa883aa0f6a_Win10_Release_Intel_HD_530__telemetry/gen/Pixel_OffscreenCanvas2DResizeOnWorker_58067513307e4ab9d0bd473670cf3fa883aa0f6a.png (publicly readable)
(INFO) 2017-02-09 10:18:55,200 cloud_storage.Insert:370  Uploading c:\b\c\b\win10_release__intel_hd_530_\itv0tfgo\tmpbrk5kd.png to gs://chromium-browser-gpu-tests/runs/58067513307e4ab9d0bd473670cf3fa883aa0f6a_Win10_Release_Intel_HD_530__telemetry/ref/Pixel_OffscreenCanvas2DResizeOnWorker_58067513307e4ab9d0bd473670cf3fa883aa0f6a.png (publicly readable)
C:\b\c\b\Win10_Release__Intel_HD_530_\irus1c8a\third_party\catapult\telemetry\telemetry\internal\image_processing\_bitmap.py:212: UserWarning: Using pure python png decoder, which could be very slow. To speed up, consider installing numpy & cv2 (OpenCV).
  'Using pure python png decoder, which could be very slow. To speed up, '
(INFO) 2017-02-09 10:18:56,934 cloud_storage.Insert:370  Uploading c:\b\c\b\win10_release__intel_hd_530_\itv0tfgo\tmpmrqjrm.png to gs://chromium-browser-gpu-tests/runs/58067513307e4ab9d0bd473670cf3fa883aa0f6a_Win10_Release_Intel_HD_530__telemetry/diff/Pixel_OffscreenCanvas2DResizeOnWorker_58067513307e4ab9d0bd473670cf3fa883aa0f6a.png (publicly readable)
See http://chromium-browser-gpu-tests.commondatastorage.googleapis.com/view_test_results.html?58067513307e4ab9d0bd473670cf3fa883aa0f6a_Win10_Release_Intel_HD_530__telemetry for this run's test results

Traceback (most recent call last):
  _RunGpuTest at content\test\gpu\gpu_tests\gpu_integration_test.py:73
    self.RunActualGpuTest(url, *args)
  RunActualGpuTest at content\test\gpu\gpu_tests\pixel_integration_test.py:193
    self.fail('Reference image did not match captured screen')
  fail at C:\b\depot_tools\python276_bin\lib\unittest\case.py:412
    raise self.failureException(msg)
AssertionError: Reference image did not match captured screen

Locals:
  msg : 'Reference image did not match captured screen'

Happens for a while:
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win10%20Release%20%28Intel%20HD%20530%29/builds/20

Image mismatch is followed by a DCHECK, not sure if related, tracking in  issue 689577 .

xlai@, I see you handle many OffscreenCanvas issues, can you please take a look?
 

Comment 1 by xlai@chromium.org, Feb 10 2017

Cc: junov@chromium.org
This is very weird; the image is not entirely wrong, only the green color portion disappears.

I couldn't reproduce this error on another Win 10 machine. DCHECK shouldn't be a problem because the same DCHECK error happens in some other passed tests as well.

Are you sure build 20 is the first build that this flakiness start to appear? The only way I can think of identifying a culprit is by looking at the list of commits happening during that time period.

junov@: Any insights that come to your mind when you see the picture?

What I've meant by build 20 is that this goes way back, so we probably don't have the history of when it started, and should just assume it was flaky forever.

Seems like this is going to take a while to investigate, so I'm going to suppress the test.

Comment 3 by xlai@chromium.org, Feb 10 2017

ynovikov@: Thanks. But could you suppress it only on this particular machine? As the test was running fine in other machines.
Summary: Pixel_OffscreenCanvas2DResizeOnWorker flaky on Win10 Intel HD 530 (was: Pixel_OffscreenCanvas2DResizeOnWorker flaky on Win10 Release (Intel HD 530) GPU.FYI)

Comment 6 by xlai@chromium.org, Feb 10 2017

Cc: ccameron@chromium.org
Some analysis:

1. I don't think this flakiness is related to resizing, not only because the size of red-color portion is correct, but also because another resizing test on webgl context does not exhibit flakiness behavior.

2. Test was created in Dec 21 but flakiness starts to appear in Jan 13 and is more frequent on Release machine than the Debug machine. There was an update of gpu reference image in Jan 12; but that update was to make the edge between green and red portion softer, not to change its size or color. And the edge in generated image here is indeed correctly softened.

For somehow, the image rendered on the screen only shows the second "fillRect" and not the first "fillRect". Not sure if this is a color-rendering problem of green pixels on Win10 Intel HD 530 specifically (+ccameron: maybe you can have some insights on the color display here? I saw quite some color-related CLs committed by you on Jan 12-13).

For now, I'm going to try landing a patch that makes use of the returned promise of commit() to see if that can solve this weird partial rendering issue.


Project Member

Comment 7 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6db2dafe177bcc8e3e22612c39b25bead34f01b

commit e6db2dafe177bcc8e3e22612c39b25bead34f01b
Author: ynovikov <ynovikov@chromium.org>
Date: Fri Feb 10 21:31:20 2017

Mark Pixel_OffscreenCanvas2DResizeOnWorker Flaky on Win10 Intel HD 530

BUG= 690663 
TBR=kbr@chromium.org, xlai@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2691523003
Cr-Commit-Position: refs/heads/master@{#449740}

[modify] https://crrev.com/e6db2dafe177bcc8e3e22612c39b25bead34f01b/content/test/gpu/gpu_tests/pixel_expectations.py

Project Member

Comment 8 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9ff9600d38e624c3caf86e2e8e4d1730ab7a34c8

commit 9ff9600d38e624c3caf86e2e8e4d1730ab7a34c8
Author: xlai <xlai@chromium.org>
Date: Fri Feb 10 21:55:32 2017

Improve Pixel_OffscreenCanvas2DResizeOnWorker test

This CL is an attempt to fix flaky Pixel_OffscreenCanvas2DResizeOnWorker on
Win10 Intel HD 530.

TBR=junov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

BUG= 690663 

Review-Url: https://codereview.chromium.org/2690663002
Cr-Commit-Position: refs/heads/master@{#449746}

[modify] https://crrev.com/9ff9600d38e624c3caf86e2e8e4d1730ab7a34c8/content/test/data/gpu/pixel_offscreenCanvas_2d_resize_on_worker.html

 Issue 809884  has been merged into this issue.
Project Member

Comment 11 by chromium...@appspot.gserviceaccount.com, Apr 7 2018

Labels: Sheriff-Chromium
Detected 3 new flakes for test/step "gpu_tests.pixel_integration_test.PixelIntegrationTest.Pixel_OffscreenCanvas2DResizeOnWorker". To see the actual flakes, please visit https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyZgsSBUZsYWtlIltncHVfdGVzdHMucGl4ZWxfaW50ZWdyYXRpb25fdGVzdC5QaXhlbEludGVncmF0aW9uVGVzdC5QaXhlbF9PZmZzY3JlZW5DYW52YXMyRFJlc2l6ZU9uV29ya2VyDA. This message was posted automatically by the chromium-try-flakes app. Since flakiness is ongoing, the issue was moved back into Sheriff Bug Queue (unless already there).
Labels: -Sheriff-Chromium
xlai@, should it be disabled on Win?

Comment 13 by xlai@chromium.org, Apr 9 2018

Components: Internals>GPU>Testing
vasilii@: The test was already disabled on Win (https://cs.chromium.org/chromium/src/content/test/gpu/gpu_tests/pixel_expectations.py?l=77). I checked up the 3 flaky cases that were posted 46 hours ago, and saw that it is a mass failure on all the pixel tests with an error message "browser not started". So, the new phenomenon is not related to this test case specifically.

Comment 14 by xlai@chromium.org, May 4 2018

I manually checked the test results (because of info unavailability of flaky test crbug.com/783263) for the latest 11 builds in Win 10 Release Intel HD 630:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20FYI%20Release%20%28Intel%20HD%20630%29
(Cannot find HD 530 bot; maybe they've upgraded it to 630 recently).
and find that this test is successful all the time.

The previous failure might be actually a device-specific issue that is not seen in Intel HD 630. I would like to enable this test; if it goes flaky again, we can reopen this issue.

Comment 15 by kbr@chromium.org, May 4 2018

Yes, the Intel HD 530 bots have been decommissioned and replaced by a larger number of Intel HD 630 bots.

Thanks for following up on this.

Project Member

Comment 16 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7dae0564c3288a89d2c2af19dcaf169c15ffe5a7

commit 7dae0564c3288a89d2c2af19dcaf169c15ffe5a7
Author: xlai <xlai@chromium.org>
Date: Fri May 04 20:20:37 2018

Enable flaky resize OffscreenCanvas test on Win 10 Intel

The previous flakiness might be a device-specific issue that is seen in Intel
HD 530 but not Intel HD 630.

Bug:  690663 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I18b2c9822bf39cfbcd233e2219ac460eb51875b6
Reviewed-on: https://chromium-review.googlesource.com/1044656
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Olivia Lai <xlai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#556173}
[modify] https://crrev.com/7dae0564c3288a89d2c2af19dcaf169c15ffe5a7/content/test/gpu/gpu_tests/pixel_expectations.py

Comment 17 by xlai@chromium.org, May 8 2018

Status: Fixed (was: Assigned)
The Win 10 Intel HD 630 does not show flakiness of this test for 50+ builds. I'll hence mark this as fixed.

Comment 18 by kbr@chromium.org, May 9 2018

Thank you for following up on this Olivia!

Sign in to add a comment