MobileFre.Progress histograms were accidentally renamed |
|||||
Issue descriptionMobileFre.Progress histograms were accidentally renamed. In a refactoring CL for removing a native dependency from FRE, I accidentally made these get logged as MobileFre.SignInChoice.MainIntent and MobileFre.SignInChoice.ViewIntent, instead of MobileFre.Progress.ViewIntent and MobileFre.Progress.ViewIntent.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e3d6c77d25e3cd97e776fa3b5427f883341c854 commit 1e3d6c77d25e3cd97e776fa3b5427f883341c854 Author: asvitkine <asvitkine@chromium.org> Date: Thu Feb 09 23:08:53 2017 Fix names of MobileFre.Progress histograms. I accidentally broke this in a refactoring here: https://codereview.chromium.org/2466723002/ BUG= 690655 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2689613002 Cr-Commit-Position: refs/heads/master@{#449450} [modify] https://crrev.com/1e3d6c77d25e3cd97e776fa3b5427f883341c854/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java
,
Feb 9 2017
,
Feb 9 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 10 2017
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb950b91fbff62f4b05095807bb6c0eba9ac4b10 commit eb950b91fbff62f4b05095807bb6c0eba9ac4b10 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Fri Feb 10 15:30:14 2017 Fix names of MobileFre.Progress histograms. I accidentally broke this in a refactoring here: https://codereview.chromium.org/2466723002/ BUG= 690655 TBR=tedchoc@chromium.org Review-Url: https://codereview.chromium.org/2689613002 Cr-Commit-Position: refs/heads/master@{#449450} (cherry picked from commit 1e3d6c77d25e3cd97e776fa3b5427f883341c854) Review-Url: https://codereview.chromium.org/2690563003 . Cr-Commit-Position: refs/branch-heads/2987@{#436} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/eb950b91fbff62f4b05095807bb6c0eba9ac4b10/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by asvitk...@chromium.org
, Feb 9 2017