New issue
Advanced search Search tips

Issue 690655 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

MobileFre.Progress histograms were accidentally renamed

Project Member Reported by asvitk...@chromium.org, Feb 9 2017

Issue description

MobileFre.Progress histograms were accidentally renamed.

In a refactoring CL for removing a native dependency from FRE, I accidentally made these get logged as MobileFre.SignInChoice.MainIntent and MobileFre.SignInChoice.ViewIntent, instead of MobileFre.Progress.ViewIntent and MobileFre.Progress.ViewIntent.
 
Broken in this CL: https://codereview.chromium.org/2466723002/

Looks like it made it into M56:

Commit 2770c135... initially landed in 56.0.2908.0

I can merge this back to M57 but means we'll live with the bad names for M56. Sorry!


Project Member

Comment 2 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e3d6c77d25e3cd97e776fa3b5427f883341c854

commit 1e3d6c77d25e3cd97e776fa3b5427f883341c854
Author: asvitkine <asvitkine@chromium.org>
Date: Thu Feb 09 23:08:53 2017

Fix names of MobileFre.Progress histograms.

I accidentally broke this in a refactoring here:
https://codereview.chromium.org/2466723002/

BUG= 690655 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2689613002
Cr-Commit-Position: refs/heads/master@{#449450}

[modify] https://crrev.com/1e3d6c77d25e3cd97e776fa3b5427f883341c854/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Labels: Merge-Request-57
Project Member

Comment 4 by sheriffbot@chromium.org, Feb 9 2017

Labels: -Merge-Request-57 Hotlist-Merge-Approved Merge-Approved-57
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 10 2017

Labels: -merge-approved-57 merge-merged-2987
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eb950b91fbff62f4b05095807bb6c0eba9ac4b10

commit eb950b91fbff62f4b05095807bb6c0eba9ac4b10
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Fri Feb 10 15:30:14 2017

Fix names of MobileFre.Progress histograms.

I accidentally broke this in a refactoring here:
https://codereview.chromium.org/2466723002/

BUG= 690655 
TBR=tedchoc@chromium.org

Review-Url: https://codereview.chromium.org/2689613002
Cr-Commit-Position: refs/heads/master@{#449450}
(cherry picked from commit 1e3d6c77d25e3cd97e776fa3b5427f883341c854)

Review-Url: https://codereview.chromium.org/2690563003 .
Cr-Commit-Position: refs/branch-heads/2987@{#436}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}

[modify] https://crrev.com/eb950b91fbff62f4b05095807bb6c0eba9ac4b10/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java

Sign in to add a comment