Play Store settings layout issue |
|||||||||||
Issue descriptionChrome Version: 58.0.3007.0 (canary) What steps will reproduce the problem? (1) Open MD settings (2) Check ARC++ section What happens instead? Layout is wacky - [Learn more] is too close to check btn. see attached image
,
Feb 9 2017
,
Feb 9 2017
Probably an artifact of a semi-recent switch from checkboxes to toggles. P2 I think, but will address for 58.
,
Feb 10 2017
Another one for you Tommy.
,
Feb 11 2017
what did this look like before?
,
Feb 11 2017
this is probbbably what you want https://codereview.chromium.org/2686423002
,
Feb 11 2017
fwiw: I don't think this looked great before the toggle -> checkbox change, but here's a potential candidate right now note: it'd *probably* be saner to have the "Learn more" link at the end of the text, which is possible, but'd take a bit of reshuffling
,
Feb 12 2017
Agreed that the "Learn more" link should be positioned at the end of the text instead of next to the toggle. Also, from the original screenshot, there shouldn't be an indent in the second row, and we'll probably want a divider between the two rows.
,
Feb 13 2017
,
Feb 14 2017
so this is mildly hard because right now the label of toggles is slotted, and can't contain HTML https://codereview.chromium.org/2686423002/ gets us to a better looking UI, but still kind of sucks (compared to what we actually want), but isn't nearly as broken.
,
Feb 14 2017
Thanks Dan! Now I get why this isn't easy.
,
Feb 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b2ebf7e74419122c83624be9d2bddd660572092f commit b2ebf7e74419122c83624be9d2bddd660572092f Author: dbeam <dbeam@chromium.org> Date: Tue Feb 14 15:11:47 2017 MD Settings: improve play store learn more link position R=tommycli@chromium.org BUG= 690653 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2686423002 Cr-Commit-Position: refs/heads/master@{#450354} [modify] https://crrev.com/b2ebf7e74419122c83624be9d2bddd660572092f/chrome/browser/resources/settings/android_apps_page/android_apps_page.html [modify] https://crrev.com/b2ebf7e74419122c83624be9d2bddd660572092f/chrome/browser/resources/settings/android_apps_page/android_apps_page.js
,
Feb 15 2017
Issue 691925 has been merged into this issue.
,
Feb 15 2017
This looks good on ToT, thanks! Marking fixed. (If you want to reopen to track the desired but more complex UX request, remove the 'Blocking 684849', thanks!)
,
Feb 22 2017
58.0.3015.0/9304.0.0 |
|||||||||||
►
Sign in to add a comment |
|||||||||||
Comment 1 by zelidrag@chromium.org
, Feb 9 2017