New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690640 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Switching Immersive Fullscreen to Real Fullscreen put the window in inconsistent state

Project Member Reported by osh...@chromium.org, Feb 9 2017

Issue description

Repro step:

1) open browser
2) open youtube and start some video
3) go immersive (f4)
4) click fullscreen

expected: no immersive caption, no auto shelf
actual: immersive caption, no auto shelf.

This is because the window stays in immersive, but ash state becomes real fulllscreen.

 
Cc: yiyix@chromium.org
Owner: tdander...@chromium.org
Status: Assigned (was: Untriaged)
@tdanderson/yiyix since you were looking at the immersive mode tabstrip for Issue 607029 could you take a look at this?
Cc: tdander...@chromium.org
Components: UI>Shell>Immersive
Labels: -Pri-3 Proj-MaterialDesign-CrOS M-58 Pri-2
Owner: warx@chromium.org
warx@, could this have been as a result of your recent changes to immersive mode handling? If not please re-assign back to me.

Comment 3 by warx@chromium.org, Feb 22 2017

It seems not reproducible on tot. It could have been fixed by the cleanup CL.
Status: WontFix (was: Assigned)

Comment 5 by osh...@chromium.org, Feb 28 2017

Status: Assigned (was: WontFix)
Still happens on the chrome I built this week.

Comment 6 by warx@chromium.org, Mar 2 2017

hmm.. I still cannot repro. For "4) click fullscreen", it is clicking the fullscreen icon on the video, right?

I don't see any difference between M56 version. It is totally immersive without caption and shelf.

Not sure how to trigger the bug. tbuckley@, if you can see it, I would like to stop by to take a look.

Thanks!
have you try to open immersive caption?

Comment 8 by warx@chromium.org, Mar 2 2017

Cc: jamescook@chromium.org
Labels: -Proj-MaterialDesign-CrOS
OK, from the comments above, I firstly thought it was a regression because of MD and my recent changes. But I could not see any difference between TOT and M56, even M54 which has no MD immersive is applied.

So this bug is all about: whether we should allow immersive tabstrip/caption/navigation bar revealed on youtube fullscreen mode?
oshima@, am I right?

-Proj-MaterialDesign-CrOS label and +jamescook@ for thoughts on if we should fix this since it apparently exists for a long time.
Cc: sky@chromium.org
oshima, is this a regression? Is the expected behavior to block the tabstrip slide-down when in YouTube fullscreen?

sky, could your mash immersive mode patches have changed this?

> oshima, is this a regression?

I filed this as a bug, not a regression :) My guess is that this has been broken in html video fullscreen,
but works with pepper fullscreen. (so you may call it regression from end user point of view)

> Is the expected behavior to block the tabstrip slide-down when in YouTube fullscreen?

Yes, it shouldn't show the tab strip at least for the current spec.


Comment 11 by sky@chromium.org, Mar 3 2017

My changes haven't really been in common code, but more in code specific to mash. I think Oshima says this is a long standing issue too, so hopefully it isn't me.

Comment 12 by warx@chromium.org, Jun 18 2018

Owner: ----
Status: Untriaged (was: Assigned)
Labels: -M-58
Owner: malaykeshav@chromium.org
Status: Assigned (was: Untriaged)
Malaykeshav@could you please triage now that Warx is gone.
Does this still happen?

Sign in to add a comment