New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690639 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 690642
issue 537368



Sign in to add a comment

LLVM: Crash when building sys-libs/pam

Project Member Reported by yunlian@chromium.org, Feb 9 2017

Issue description

https://uberchromegw.corp.google.com/i/chromiumos/builders/chromiumos-sdk/builds/7701

pam-1.2.1-r1: ../../Linux-PAM-1.2.1/libpam/pam_handlers.c:285:9: warning: unused variable 'err' [-Wunused-variable]
pam-1.2.1-r1:     int err = 0;
pam-1.2.1-r1:         ^
pam-1.2.1-r1: fatal error: error in backend: unsupported relocation on symbol
pam-1.2.1-r1: clang-4.0: error: clang frontend command failed with exit code 70 (use -v to see invocation)
pam-1.2.1-r1: Chromium OS 4.0_pre285905-r3 clang version 4.0.0 (/var/cache/chromeos-cache/distfiles/host/egit-src/clang.git 47592b1815f5423fa708fca47741886043e6bb32) (/var/cache/chromeos-cache/distfiles/host/egit-src/llvm.git 77e7778b3e097ad88c71c7dac789e245c8f3e33a) (based on LLVM 4.0.0svn)
pam-1.2.1-r1: Target: armv7a-cros-linux-gnueabi
pam-1.2.1-r1: Thread model: posix
pam-1.2.1-r1: InstalledDir: /usr/bin
pam-1.2.1-r1: clang-4.0: note: diagnostic msg: PLEASE submit a bug report to http://llvm.org/bugs/ and include the crash backtrace, preprocessed source, and associated run script.
pam-1.2.1-r1: clang-4.0: note: diagnostic msg: 
pam-1.2.1-r1: ********************
pam-1.2.1-r1: 
pam-1.2.1-r1: PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
pam-1.2.1-r1: Preprocessed source(s) and associated run script(s) are located at:
pam-1.2.1-r1: clang-4.0: note: diagnostic msg: /build/arm-generic/tmp/portage/sys-libs/pam-1.2.1-r1/temp/pam_handlers-d9d0c8.c
pam-1.2.1-r1: clang-4.0: note: diagnostic msg: /build/arm-generic/tmp/portage/sys-libs/pam-1.2.1-r1/temp/pam_handlers-d9d0c8.sh
pam-1.2.1-r1: clang-4.0: note: diagnostic msg: 
pam-1.2.1-r1: 
pam-1.2.1-r1: ********************
 
Labels: -Pri-3 Pri-1
Cc: cmt...@chromium.org
Sent a change to build pam by gcc before we can figure out the issue.
So far, I am not able to reproduce the issue locally when building packages for arm-generic.
The issue seems to be with the gcc update.
Building clang with new gcc triggers the fail, but if older gcc is used to build clang, the package builds fine.
So maybe there is a bug in gcc.

Comment 5 by yunlian@google.com, Feb 10 2017

Tot llvm still has this issue.

Comment 6 by laszio@chromium.org, Feb 10 2017

Shall we add USE=clang to llvm?

Comment 7 by lloz...@google.com, Feb 10 2017

that would not help if the problem is in GCC. 

Comment 8 by laszio@chromium.org, Feb 10 2017

'USE=clang sudo merge llvm' will use clang to build llvm. Doesn't this sidestep the bug in gcc (if any)?

Comment 9 by cmtice@google.com, Feb 10 2017

That might side-step the issue, but if there is a real bug in the GCC update then I need to revert the GCC update & find and fix the bug.
Verified that the crash started with llvm upgrade on Jan 23.
Older clang version does not crash when built with the updated gcc.
Project Member

Comment 11 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/cfb2f16ccd8359c12b7ad50e5a0a5d9dbe1d63ab

commit cfb2f16ccd8359c12b7ad50e5a0a5d9dbe1d63ab
Author: Caroline Tice <cmtice@google.com>
Date: Fri Feb 10 18:17:42 2017

Revert CL 438688 manifest: Update GCC pinned version.

The latest version of LLVM, when built with the updated version
of GCC, fails while building sys-libs/pam.   (LLVM updated
after this patch was tested.) We need to revert the GCC update
while this issue is debugged and fixed.

BUG= chromium:690639 
CQ-DEPEND=CL:*326505
TEST=clang built with this version of GCC has the issue; clang
built with the old version of GCC does not.

Change-Id: I287396782330cd8f8a180f3ca9d3a9887df09bd6
Reviewed-on: https://chromium-review.googlesource.com/440468
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/cfb2f16ccd8359c12b7ad50e5a0a5d9dbe1d63ab/full.xml

Project Member

Comment 12 by bugdroid1@chromium.org, Feb 10 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/7d0e22411082558e44ac736c5e45bb438f59a688

commit 7d0e22411082558e44ac736c5e45bb438f59a688
Author: Caroline Tice <cmtice@google.com>
Date: Fri Feb 10 18:17:57 2017

Assign to cmtice@.
Cc: laszio@chromium.org llozano@chromium.org yunlian@chromium.org
Owner: cmt...@chromium.org
Blocking: 690642
The problem turns out to be a problem with LLVM, rather than GCC.  (see http://bugs.llvm.org/show_bug.cgi?id=31997 ).  We are currently exploring our options for getting LLVM properly fixed and rolling the GCC security fix back into ChromeOS.  We cannot push the new version of GCC into ChromeOS until we deal with this LLVM failure (which the new GCC exposes).
Blocking: 537368
Cc: manojgupta@chromium.org
Summary: LLVM: Crash when building sys-libs/pam (was: chromiumos-sdk bot failed)
Update title.
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82

commit 1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Feb 24 18:22:07 2017

LLVM: Pick 3 upstream fixes.

Fixes errors in handling objectsize builtin in clang
and fix compilation crash in sys-libs/pam.
Apply objectSize fixes only to llvm-next.

BUG= chromium:690639 ,  chromium:694679 
TEST=Errors not seen when building for veyron_jaq, cbuildbot testing
for falco, elm and veyron_jaq.

Change-Id: If84e2e9bf829fd6839ea97ca82b486ae40f8671a
Reviewed-on: https://chromium-review.googlesource.com/446527
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[rename] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/llvm-4.0_pre285905-r5.ebuild
[add] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/files/cherry/93418eeb1d886747332ff404f0e2651e8d77879a.patch
[add] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/files/cherry/fbe18a269deb1a11c16eb2d2419b3c9ef9be8d3b.patch
[add] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/files/cherry/e604e8210fa49cfe23fb262e228d40734eaed141.patch

Project Member

Comment 20 by bugdroid1@chromium.org, Feb 24 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82

commit 1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Feb 24 18:22:07 2017

LLVM: Pick 3 upstream fixes.

Fixes errors in handling objectsize builtin in clang
and fix compilation crash in sys-libs/pam.
Apply objectSize fixes only to llvm-next.

BUG= chromium:690639 ,  chromium:694679 
TEST=Errors not seen when building for veyron_jaq, cbuildbot testing
for falco, elm and veyron_jaq.

Change-Id: If84e2e9bf829fd6839ea97ca82b486ae40f8671a
Reviewed-on: https://chromium-review.googlesource.com/446527
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>

[rename] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/llvm-4.0_pre285905-r5.ebuild
[add] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/files/cherry/93418eeb1d886747332ff404f0e2651e8d77879a.patch
[add] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/files/cherry/fbe18a269deb1a11c16eb2d2419b3c9ef9be8d3b.patch
[add] https://crrev.com/1c00ef346cf9eeeaba2fb7a6f6b15f00b944cd82/sys-devel/llvm/files/cherry/e604e8210fa49cfe23fb262e228d40734eaed141.patch

Status: Fixed (was: Untriaged)
Building pam should not crash any more after picking upstream fix.
The new version of GCC has been pushed again; this time it passed the chromiumos-sdk builder.
Status: Verified (was: Fixed)

Sign in to add a comment