The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/gobi3k-sdk/+/29b8bd5052e007873c47ece416f324ba50f83bb4

commit 29b8bd5052e007873c47ece416f324ba50f83bb4
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 10 04:48:44 2017

Add missing return statement to Run() in GobiQDLService/Main.cpp

BUG= chromium:690629 
TEST=Run unit tests and network3g tests with Gobi3k modem.

Change-Id: I6bc58aed47364022b323a558dd028d67052cf0cf
Reviewed-on: https://chromium-review.googlesource.com/440370
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/29b8bd5052e007873c47ece416f324ba50f83bb4/GobiQDLService/Main.cpp

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/gobi3k-sdk/+/0b4477c48f60fa66a306d4a4a2514f3454376705

commit 0b4477c48f60fa66a306d4a4a2514f3454376705
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 10 04:48:44 2017

Define virtual destructor in cProtocolNotification.

The code deletes cProtocolQueueNotification via its
cProtocolNotification abstract base class, which requires
cProtocolNotification to define a virtual destructor.

The issue is reported by the following compiler warning:

    ../Core/ProtocolRequest.cpp:251:7: error: delete called on
    'cProtocolNotification' that is abstract but has non-virtual destructor
    [-Werror,-Wdelete-non-virtual-dtor]
          delete mpNotifier;
          ^

BUG= chromium:690629 
TEST=Run unit tests and network3g tests with Gobi3k modem.

Change-Id: I64fd4f33519ecb652c478c31d4ad089a4c994f32
Reviewed-on: https://chromium-review.googlesource.com/440371
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0b4477c48f60fa66a306d4a4a2514f3454376705/Core/ProtocolNotification.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/gobi3k-sdk/+/5e5d1a65cbf855609e4d7c9c425615090a834704

commit 5e5d1a65cbf855609e4d7c9c425615090a834704
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 10 04:48:45 2017

Turn compiler warnings into errors.

Gobi code still has lots of other compiler warnings if we turn on -Wall
and -Wextra. For now, we turn on -Werror to catch the default warnings
like -Wreturn-type.

BUG= chromium:690629 
TEST=Build and run unit tests.

Change-Id: I2e5660e95e58442e779bfcea2bce0545752897a4
Reviewed-on: https://chromium-review.googlesource.com/440373
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/5e5d1a65cbf855609e4d7c9c425615090a834704/Makefile

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/gobi3k-sdk/+/c9b5bb6cdf62abeb5b3a526c8d260656dff38f80

commit c9b5bb6cdf62abeb5b3a526c8d260656dff38f80
Author: Ben Chan <benchan@chromium.org>
Date: Fri Feb 10 04:48:45 2017

Fix usage of std::string::find() in cGobiQMICore::GetImageInfo().

The return value of std::string::find() should be checked against
std::string::npos to determine if the substring isn't found.

The issue is reported by the following compiler warning:

  ../Shared/GobiQMICoreImg2k.cpp:441:35: error: comparison of unsigned
  expression < 0 is always false [-Werror,-Wtautological-compare]
     if (tmpPath.find( imageStore ) < 0)
         ~~~~~~~~~~~~~~~~~~~~~~~~~~ ^ ~

BUG= chromium:690629 
TEST=Run unit tests and network3g tests with Gobi3k modem.

Change-Id: Id620e5539cbec2fbb93e095198c8f98a8dad6cef
Reviewed-on: https://chromium-review.googlesource.com/440372
Commit-Ready: Ben Chan <benchan@chromium.org>
Tested-by: Ben Chan <benchan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c9b5bb6cdf62abeb5b3a526c8d260656dff38f80/Shared/GobiQMICoreImg2k.cpp