MD Settings: Unable to open Mouse and touchpad settings section in chromebox |
|||||||
Issue descriptionGoogle Chrome 57.0.2987.35 (Official Build) beta (64-bit) Revision 0 Platform 9202.21.0 (Official Build) beta-channel ninja What steps will reproduce the problem? 1. Open settings 2. Search for "touch" keyword 3. In the display results, click on Manage accessibility features -> Scroll down to mouse and touchpad section -> Click on "Open mouse and touchpad device settings" What is the expected result? "Open mouse and touchpad device settings" page should be displayed What happens instead? Goes back to previous page. Attached video.
,
Feb 9 2017
I can not reproduce this on 58, I suspect it has been addressed. ->dpapad@ to confirm WontFix or address.
,
Feb 12 2017
This seem like a search issue. I can repro on a normal Chromebook by searching for "mouse" instead: 1. Open MD Settings 2. Search for "mouse" 3. In the results, click on Manage accessibility features 4. Click "Open mouse and touchpad device settings" Expected: touchpad subpage opens Actual: touchpad subpage does not open
,
Feb 12 2017
Version: 58.0.3007.0 (Official Build) dev (64-bit)
,
Feb 21 2017
I can repro this also on ToT. The problem appears to be related to the fact that 'mouse' is not listed on a touchpad device (or vice versa on a chromebox), so the search result is empty.
,
Feb 21 2017
Looking...
,
Feb 21 2017
@stevenjb: I am not able to reproduce (running ChromeOS on Linux), see attached screencast.
,
Feb 22 2017
@dpapad that's probably because you are showing that both a mouse and trackpad are present. Most Chromebooks only have one or the other, so the section won't be called "Mouse and Trackpad" and therefore won't match the search query (while the row in Accessibility is always "mouse and trackpad", so it always matches).
,
Feb 22 2017
On Linux on CrOS you can visit chrome://device-emulator to set up fake input devices. Enable Touchpad and disable Mouse, then open Settings and search for Mouse... or vice versa. Presumably, navigating to a different section should clear the search results.
,
Feb 22 2017
I'll try disabling mouse shortly. Thanks. > Presumably, navigating to a different section should clear the search results. Search only filters out top-level <settings-section> elements. When navigating from a top-level result to a subpage, there should be nothing hidden in the subpage. If we are navigating to a different <settings-section> then yes, the results should be cleared (and should be reflected in the URL too).
,
Feb 22 2017
I've found the problem, and have a candidate fix.
,
Feb 22 2017
,
Feb 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e1a5f4de7e19dd33e3781609dd325fa715f354d2 commit e1a5f4de7e19dd33e3781609dd325fa715f354d2 Author: dpapad <dpapad@chromium.org> Date: Thu Feb 23 00:30:37 2017 MD Settings: Manage a11y page, clear search param when navigating. Navigating to a different page requires clearing the search parameter, so that the page exits search mode. This is identical with what the settings-menu does when navigating while in search mode. BUG= 690620 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2713553004 Cr-Commit-Position: refs/heads/master@{#452307} [modify] https://crrev.com/e1a5f4de7e19dd33e3781609dd325fa715f354d2/chrome/browser/resources/settings/a11y_page/manage_a11y_page.js
,
Feb 23 2017
,
Mar 21 2017
9334.15.0 / 58.0.3029.19 |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by abodenha@chromium.org
, Feb 9 2017Labels: -M-57 M-58
Owner: steve...@chromium.org
Status: Assigned (was: Untriaged)