New issue
Advanced search Search tips

Issue 690619 link

Starred by 1 user
Status: WontFix
Owner:
grt@chromium.org
Closed: Feb 2017
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

[Missing Tests]:Crash: MainDllLoader::Launch

Project Member Reported by ligim...@chromium.org, Feb 9 2017 
Automated tests for the below commit have been missing.

Greg, this is a crash fix with no repro steps, wondering whether there is a possibility of adding any tests to avoid regressions in future.

CL:
https://codereview.chromium.org/2578483002

Reference bug:
https://bugs.chromium.org/p/chromium/issues/detail?id=674541

Comment 1 by grt@chromium.org, Feb 10 2017

Status: WontFix (was: Assigned)
Summary: [Missing Tests]:Crash: MainDllLoader::Launch (was: [Missing Tests]:UnlockProfileAndHideLoginUI()Crash: MainDllLoader::Launch)
Hi Ligimole. I think you may have pointed me to the wrong CL -- I don't recognize that one. Regarding issue 674541, however, my commit for it is a workaround for a crash caused by Avast rather than a true bug in Chrome that we can fix. Our existing tests that run the browser already act as a regression test of sorts.

Since Avast causes all sorts of crashes, it may be interesting to set up some test machines with Avast installed that run automated tests. It's possible that we could workaround some other crashes caused by Avast. Then again, I'm not convinced that it's worth our effort if we only learn that Avast makes Chrome crash and there's little we can do about it.
►

Sign in to add a comment