New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 690612 link

Starred by 1 user
Status: Verified
Owner:
█ mka@chromium.org
Last visit > 30 days ago
Closed: Jul 2017
Cc:
derat@chromium.org
snanda@chromium.org
tbroch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 214886



Sign in to add a comment

Configure SATA link power management with udev rule

Project Member Reported by mka@chromium.org, Feb 9 2017 
This setting is currently handled by laptop-mode-tools (LMT), which we intend to replace ( Issue 214886 ).

The configuration is done through a single sysfs attribute (/sys/class/scsi_host/hostN/link_power_management_policy). On CrOS the value is always "min_power", regardless of whether running on battery or with line power.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3b7edce596077b0ee9977598a4a1eddeb0291abd

commit 3b7edce596077b0ee9977598a4a1eddeb0291abd
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Jul 14 02:45:54 2017

laptop-mode-tools: Disable SATA link power management

This setting is now handled through a udev rule

BUG= chromium:690612 ,  chromium:214886 
TEST=emerge-lumpy laptop-mode-tools
  cros deploy ${DUT} laptop-mode-tools
  reboot ${DUT}
  cat /sys/class/scsi_host/host0/link_power_management_policy
    => max_performance
CQ-DEPEND=CL:568592

Change-Id: Ie1253723b5120458f4625f4ea4e1562750f34adc
Reviewed-on: https://chromium-review.googlesource.com/568591
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[rename] https://crrev.com/3b7edce596077b0ee9977598a4a1eddeb0291abd/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59-r44.ebuild
[add] https://crrev.com/3b7edce596077b0ee9977598a4a1eddeb0291abd/app-laptop/laptop-mode-tools/files/0038-disable-intel-sata-powermanagement.patch
[modify] https://crrev.com/3b7edce596077b0ee9977598a4a1eddeb0291abd/app-laptop/laptop-mode-tools/laptop-mode-tools-1.59.ebuild

Comment 2 by mka@chromium.org, Jul 14 2017

Status: Verified (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 6 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/d8d2c00829f75f12422c920a617c76a9416ebcbc

commit d8d2c00829f75f12422c920a617c76a9416ebcbc
Author: Matthias Kaehlcke <mka@chromium.org>
Date: Fri Jul 14 02:45:54 2017

power: Add udev rule to minimize link power for SATA drives

This setting was previously handled by laptop-mode-tools (LMT). With
LMT a static setting (min_power) is used, this can be replaced with a
udev rule.

BUG= chromium:690612 ,  chromium:214886 
TEST=cros_workon-lumpy start power_manager
  # with CL:568591
  emerge-lumpy laptop-mode-tools power_manager
  cros deploy ${DUT} power_manager laptop-mode-tools
  reboot ${DUT}
  cat /sys/class/scsi_host/host0/link_power_management_policy
    => min_power
CQ-DEPEND=CL:568591

Change-Id: I4e26bd95a483718cad9da83a39d2a1b3fd54b574
Reviewed-on: https://chromium-review.googlesource.com/568592
Commit-Ready: Matthias Kaehlcke <mka@chromium.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/d8d2c00829f75f12422c920a617c76a9416ebcbc/power_manager/udev/optional/99-powerknobs.rules
►

Sign in to add a comment