Add Touch Bar support for fullscreen |
||||||
Issue descriptionFor fullscreen mode we should provide an explicit “Exit Full Screen” item with persistent origin indicator (see screenshot). One slight wrinkle/complication: when you enter fullscreen today you see an overlay window that says “Press Esc to exit fullscreen”. When using a Touch Bar Mac we should prefer the message, “Press Exit Full Screen” but we can’t know whether or not a Touch Bar is visible. So the message will say “Press Esc to exit fullscreen” but the Touch Bar will display an “Exit Full Screen” button and no Esc button. We should explore the possibility of detecting the touch bar but if it's not possible it's not the end of the world. Shooting for M58 but seems unlikely given that feature freeze is in 8 days.
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b6d37d2e75d890832ab6f473eba2283c74468fb5 commit b6d37d2e75d890832ab6f473eba2283c74468fb5 Author: spqchan <spqchan@chromium.org> Date: Fri Apr 28 19:51:41 2017 [Mac] Fullscreen Touch Bar Support When in tab fullscreen, replace the ESC button with "Exit Fullscreen" and display the origin URL of the tab content in the Touch Bar. A test for this is added in BrowserTouchBarUnitTest BUG= 690611 Review-Url: https://codereview.chromium.org/2816743006 Cr-Commit-Position: refs/heads/master@{#468099} [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/base/mac/sdk_forward_declarations.h [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/chrome/app/generated_resources.grd [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/chrome/browser/ui/cocoa/browser_window_touch_bar.h [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm [modify] https://crrev.com/b6d37d2e75d890832ab6f473eba2283c74468fb5/ui/base/cocoa/touch_bar_forward_declarations.h
,
May 4 2017
,
May 4 2017
,
May 4 2017
Reopening this for a sec - when I go fullscreen in 60.0.3088.3 the touch bar's buttons don't change. They are the regular set of buttons rather than the Exit Fullscreen button. And, even though there's the default "esc" button, tapping it does not exit me out of fullscreen. Any ideas?
,
May 4 2017
Browser fullscreen or tab content fullscreen?
,
May 4 2017
Control-Cmd F. I see now - it's content fullscreen only. That makes sense, but it should be the only button we place in the toolbar at that point. Right now the others (Back, Forward, Home, etc.) are all there, but it does not make sense to use them in content fullscreen mode.
,
May 4 2017
I see what happened. You played with the customization before you tested the fullscreen touch bar right? Restore to the default touch bar and try again. The rest of the buttons should disappeared. I have an easy fix for this, I'll get it in tomorrow
,
May 4 2017
Ah, that was it. The fullscreen button and URL string look very nice. bettes@ - we're looking to ship touch bar fullscreen support in M60, with the rest of the touch bar support. You should add what spqchan@ has done to your UI review deck.
,
May 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e01a3a5f99941448100d68e92c76f5ae172595ee commit e01a3a5f99941448100d68e92c76f5ae172595ee Author: spqchan <spqchan@chromium.org> Date: Fri May 05 23:36:50 2017 [Mac] Fix for Tab Fullscreen Touch Bar The touch bar for tab fullscreen should get its own identifier. Otherwise, editing the default browser touch bar will have an effect on it. BUG= 690611 Review-Url: https://codereview.chromium.org/2860163004 Cr-Commit-Position: refs/heads/master@{#469801} [modify] https://crrev.com/e01a3a5f99941448100d68e92c76f5ae172595ee/chrome/browser/ui/cocoa/browser_window_touch_bar.h [modify] https://crrev.com/e01a3a5f99941448100d68e92c76f5ae172595ee/chrome/browser/ui/cocoa/browser_window_touch_bar.mm [modify] https://crrev.com/e01a3a5f99941448100d68e92c76f5ae172595ee/chrome/browser/ui/cocoa/browser_window_touch_bar_unittest.mm
,
May 9 2017
,
Jun 10 2017
,
Jul 20 2017
#13 shows the updated UI |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by spqc...@chromium.org
, Feb 11 2017