JsTranslateManagerTest.PerformancePlaceholder is disabled |
||||||||||
Issue descriptionThe test fails with something like the following: [ RUN ] JsTranslateManagerTest.PerformancePlaceholder ../../components/translate/ios/browser/js_translate_manager_unittest.mm:62: Failure The difference between timeElapsed and intervalInSeconds * 1000 is 151.90500000000003, which exceeds 100, where timeElapsed evaluates to 451.90500000000003, intervalInSeconds * 1000 evaluates to 300, and 100 evaluates to 100. [ FAILED ] JsTranslateManagerTest.PerformancePlaceholder (683 ms) Recent occurences: http://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyHwsSBUZsYWtlIhRjb21wb25lbnRzX3VuaXR0ZXN0cww Specific occurences: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-simulator%2F152237%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests__iPad_Air_2_iOS_10.0_%2F0%2Fstdout https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2Fios-simulator%2F152198%2F%2B%2Frecipes%2Fsteps%2Fcomponents_unittests__iPhone_5_iOS_10.0_%2F0%2Fstdout
,
Sep 14 2017
Disabled tests should be RBB
,
Sep 15 2017
To sdefresne@ as owner of translate.
,
Oct 3 2017
Please fix this before M63 branch on Oct 12th.
,
Oct 3 2017
,
Oct 10 2017
Sylvain, are you also taking a look at this test?
,
Oct 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f08a9a2c6fb656227b17a6e98713d6a19546d6b2 commit f08a9a2c6fb656227b17a6e98713d6a19546d6b2 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Oct 13 10:22:24 2017 Enable JsTranslateManagerTest.PerformancePlaceholder test. Rewrite the test to check that the time delta measured with javascript performance.now() is at least greater than the sleep timeout and also smaller than the delta measured in process with NSDate. Bug: 690607 Change-Id: I4295aa80b69701b56774b3f9d2006b2b9c76b755 Reviewed-on: https://chromium-review.googlesource.com/716230 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#508664} [modify] https://crrev.com/f08a9a2c6fb656227b17a6e98713d6a19546d6b2/components/translate/ios/browser/js_translate_manager_unittest.mm
,
Oct 13 2017
,
Oct 14 2017
[Auto-generated comment by a script] We noticed that this issue is targeted for M-63; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-63 label, otherwise remove Merge-TBD label. Thanks.
,
Oct 15 2017
,
Oct 16 2017
Your change meets the bar and is auto-approved for M63. Please go ahead and merge the CL to branch 3239 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Oct 16 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/49d104646dc61239a8f6edab51ab30ebd19243e9 commit 49d104646dc61239a8f6edab51ab30ebd19243e9 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Oct 16 20:37:46 2017 Enable JsTranslateManagerTest.PerformancePlaceholder test. Rewrite the test to check that the time delta measured with javascript performance.now() is at least greater than the sleep timeout and also smaller than the delta measured in process with NSDate. Bug: 690607 Change-Id: I4295aa80b69701b56774b3f9d2006b2b9c76b755 Reviewed-on: https://chromium-review.googlesource.com/716230 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#508664}(cherry picked from commit f08a9a2c6fb656227b17a6e98713d6a19546d6b2) Reviewed-on: https://chromium-review.googlesource.com/721243 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/branch-heads/3239@{#18} Cr-Branched-From: adb61db19020ed8ecee5e91b1a0ea4c924ae2988-refs/heads/master@{#508578} [modify] https://crrev.com/49d104646dc61239a8f6edab51ab30ebd19243e9/components/translate/ios/browser/js_translate_manager_unittest.mm
,
Jan 24 2018
|
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by briander...@chromium.org
, Feb 9 2017Status: Available (was: Untriaged)