Investigate external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html test failure |
|||
Issue descriptionImported in https://codereview.chromium.org/2647353009/ The green has the right size but the red is bigger..?
,
Feb 9 2017
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fbfd7490c876078719caf9867575b9a0826b2ba commit 2fbfd7490c876078719caf9867575b9a0826b2ba Author: cbiesinger <cbiesinger@chromium.org> Date: Mon Feb 13 00:05:26 2017 [css-flexbox] Correctly size flex rows with scrollbars Flex items with overflow: scroll were not handled correctly when they *don't* need to be stretched. We would double-count the scrollbar height. This also merges constrainedChildIntrinsicContentLogicalHeight into its only caller, which I think makes the code a bit clearer. Found thanks to a new W3C test. It also fixes a TODO. R=eae@chromium.org BUG= 690596 TEST=external/csswg-test/css-flexbox-1/layout-algorithm_algo-cross-line-001.html Review-Url: https://codereview.chromium.org/2694463002 Cr-Commit-Position: refs/heads/master@{#449902} [modify] https://crrev.com/2fbfd7490c876078719caf9867575b9a0826b2ba/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/2fbfd7490c876078719caf9867575b9a0826b2ba/third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp
,
Feb 13 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by cbiesin...@chromium.org
, Feb 9 2017