New issue
Advanced search Search tips

Issue 690591 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

The build logs should probably link to the bot's recipe

Project Member Reported by sebmarchand@chromium.org, Feb 9 2017

Issue description

It'd be pretty convenient to have a direct link to the recipe that has been used to make a build in the log, e.g. on this page: https://build.chromium.org/p/chromium.fyi/builders/Chromium%20Win%20PGO%20Builder/builds/7005 you'll get a link to https://cs.chromium.org/chromium/build/scripts/slave/recipes/chromium_pgo.py?l=1&rcl=ff817739f3d37f076695af9e8b218c044e5c83fd

This will make debugging of build issues easier.
 
Components: -Infra Infra>Platform>Recipes Infra>Platform>Milo

Comment 2 by estaab@chromium.org, Feb 10 2017

Status: Available (was: Untriaged)
This seems like a good idea. Keeping pri-3 for now.
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/external/github.com/luci/luci-go.git/+/d82ae617400d678575c2a8d877fcf1c9f2c44b03

commit d82ae617400d678575c2a8d877fcf1c9f2c44b03
Author: hinoka <hinoka@google.com>
Date: Thu Mar 02 04:55:49 2017

Milo: Remove swarming tags from build properties

This makes the build view look cleaner.  This moves info from the swarming tag
onto other places like the execution and sourcestamp sections.

BUG=632898, 690591

Review-Url: https://codereview.chromium.org/2669473002

[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/api/resp/build.go
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/buildbot/expectations/CrWinGoma.30608.build.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/buildbot/expectations/win_chromium_rel_ng.246309.build.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-canceled.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-exception.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-expired.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-link.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-nested.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-patch-failure.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-pending-logdog.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-pending.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-running-logdog.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-running.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-timeout.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/bootstrap-swarming.TestableBuild-build-unicode.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_CrWinGoma_30608.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-buildbot.TestableBuild-Debug_page-_win_chromium_rel_ng_246309.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-canceled.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-exception.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-expired.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-link.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-nested.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-patch-failure.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-pending-logdog.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-pending.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running-logdog-no-annotation-stream.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running-logdog.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-running.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-timeout.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/expectations/buildbot-swarming.TestableBuild-build-unicode.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/frontend/templates/buildbot/pages/build.html
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/build.go
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-canceled.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-exception.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-expired.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-link.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-nested.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-patch-failure.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-pending-logdog.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-pending.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-running-logdog-no-annotation-stream.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-running-logdog.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-running.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-timeout.json
[modify] https://crrev.com/d82ae617400d678575c2a8d877fcf1c9f2c44b03/milo/appengine/swarming/expectations/build-unicode.json

Milo will now link to the repo (and revision, if specified) of a luci build.  It won't link to the exact recipe since it differs depending on the repo and requires another lookup.
Project Member

Comment 5 by sheriffbot@chromium.org, May 16 2018

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 6 by mar...@chromium.org, May 21 2018

Labels: -Hotlist-Recharge-Cold
Owner: hinoka@chromium.org
Status: Assigned (was: Untriaged)
Ryan, was this fixed?

Comment 7 by no...@chromium.org, May 21 2018

I think this feature was implemented only for Buildbot 

Comment 8 by hinoka@chromium.org, May 21 2018

This current implementation pulls recipe_name and recipe_repo out of swarming tags.  This worked at one point for LUCI builds, but has since broke.  This doesn't work for cipd recipe packages since "recipe_repo" was replaced with "recipe_package".

This should be an easy fix.
Cc: -iannucci@chromium.org iannu...@google.com

Sign in to add a comment