New issue
Advanced search Search tips

Issue 690581 link

Starred by 1 user
Status: Assigned
Owner:
thakis@chromium.org
Cc:
eugene...@chromium.org
rohitrao@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

[git cl format] Formatting of ObjC methods w/o text before : formats poorly.

Project Member Reported by pkl@chromium.org, Feb 9 2017 
Some iOS API have method signatures without text before :. For example, CAMediaTimingFunction initWithControlPoints:::: (see https://developer.apple.com/reference/quartzcore/camediatimingfunction/1522235-initwithcontrolpoints)

Human format would look like this:
[[CAMediaTimingFunction alloc] initWithControlPoints:0.0f :0.84f :0.13f :0.99f]

git cl format generated this:
  return [[CAMediaTimingFunction alloc] initWithControlPoints:
                                                         0.0f:
                                                        0.84f:
                                                        0.13f:0.99f];

Comment 2 by thakis@chromium.org, Feb 9 2017 

I know about this bug, but I had no idea that there are actually Cocoa APIs that use this obscure spelling (a new api even). What were they thinking! Thanks for the report.

Comment 3 by pkl@chromium.org, Feb 9 2017

Cc: -thakis@chromium.org
Owner: thakis@chromium.org
Status: Assigned (was: Untriaged)
Yes, that's a very silly looking API :(

Comment 4 by sergeybe...@chromium.org, Dec 22 2017

Components: Infra>Client>Chrome

Comment 5 by sergeybe...@chromium.org, Dec 22 2017

Components: -Infra>Client>iOS
Moved all Infra>Client>iOS bugs to Infra>Client>Chrome + OS-iOS.

Comment 6 by lod@chromium.org, Aug 10

Cc: -lod@chromium.org

Comment 7 by smaier@chromium.org, Nov 27 

      return [[CAMediaTimingFunction alloc] initWithControlPoints:                                                  
                                                             0.0f:
                                                             0.0f:
                                                             0.2f:1.0f];
Is now:

      return [[CAMediaTimingFunction alloc]
          initWithControlPoints:
                           0.0f:0.84f:0.13f:0.99f];


I'm not sure if this is fixed.
►

Sign in to add a comment