Make the registration of the recovery component explicit on the platform |
||
Issue descriptionThe recovery component must be registered for Google builds of Chrome, on Windows or Mac. Make this assertion above obvious in the component registration code.
,
Feb 9 2017
,
Feb 10 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18e2d51bf90c1c88b1f8c5ed0cde3147ba7dda28 commit 18e2d51bf90c1c88b1f8c5ed0cde3147ba7dda28 Author: bsep <bsep@chromium.org> Date: Fri Feb 10 01:17:08 2017 Revert of Simplify the registration of the Chrome Recovery component. (patchset #2 id:20001 of https://codereview.chromium.org/2686863004/ ) Reason for revert: Causing a build failure on Linux x64. Example failure: https://uberchromegw.corp.google.com/i/chromium.chrome/builders/Google%20Chrome%20Linux%20x64/builds/16208 Original issue's description: > Simplify the registration of the Chrome Recovery component. > > BUG= 690574 > > Review-Url: https://codereview.chromium.org/2686863004 > Cr-Commit-Position: refs/heads/master@{#449439} > Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58e40e98f472ee TBR=sky@chromium.org,waffles@chromium.org,sorin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 690574 Review-Url: https://codereview.chromium.org/2683113006 Cr-Commit-Position: refs/heads/master@{#449500} [modify] https://crrev.com/18e2d51bf90c1c88b1f8c5ed0cde3147ba7dda28/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/18e2d51bf90c1c88b1f8c5ed0cde3147ba7dda28/chrome/browser/component_updater/recovery_component_installer.cc
,
Feb 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c84a7d30ef832b6e29904ccba7213f628d206654 commit c84a7d30ef832b6e29904ccba7213f628d206654 Author: sorin <sorin@chromium.org> Date: Mon Feb 13 20:05:48 2017 Simplify the registration of the Chrome Recovery component. BUG= 690574 Review-Url: https://codereview.chromium.org/2686863004 Cr-Original-Commit-Position: refs/heads/master@{#449439} Committed: https://chromium.googlesource.com/chromium/src/+/ff39aeb77a4a4e1679cfc5feed58e40e98f472ee Review-Url: https://codereview.chromium.org/2686863004 Cr-Commit-Position: refs/heads/master@{#450057} [modify] https://crrev.com/c84a7d30ef832b6e29904ccba7213f628d206654/chrome/browser/chrome_browser_main.cc [modify] https://crrev.com/c84a7d30ef832b6e29904ccba7213f628d206654/chrome/browser/component_updater/recovery_component_installer.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Feb 9 2017