MD Settings: Subpages don't take full height, or have unnecessary extra scroll space. |
|||||||
Issue descriptionRepro steps - Open chrome://md-settings - Navigate to the passwords subpage (or any subpage) Expected The subpage takes full page height, regardless of its contentn Actual The subpage does not have full page height. I think this is a regression, and suspecting https://codereview.chromium.org/2682853002. Scott, can you take a look (see attachment)? The fade-in animation to a subpage looks a bit broken. Also the "Search engines page", even though it still takes full height, has unnecessary scroll space.
,
Feb 10 2017
I did a build bisect which landed on https://chromium.googlesource.com/chromium/src/+log/7f3c2b8170c9058511d39135cfa1ff7cf0c9a668..443064bb9932a98ad47c1cbbf8bba2493a31f888. Suspecting https://chromium.googlesource.com/chromium/src/+/f7247aef78ab5a3aa4cc8d61431893bdb6b4e68f from that range.
,
Feb 10 2017
I confirmed locally that https://codereview.chromium.org/2660383002 (idle loading of advanced page), is the culprit.
,
Feb 10 2017
I was just looking at subpage heights 2 days ago, and remember seeing a "height:100%" applied to #advancedPage, which isn't being applied anymore. Suspecting the lazy-load change prevented some sort of animation from applying a height attribute. Verified on Tip of Tree that adding "height: 100%" and removing the "margin-bottom:3px" would fix the issue (see screenshot), but not sure what that entails for the lazy-load process, so I'll let dschuyler@ take a look instead.
,
Feb 10 2017
,
Feb 10 2017
,
Feb 14 2017
,
Feb 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0178428f6e9f682eb526fe95b78374448f40d9ff commit 0178428f6e9f682eb526fe95b78374448f40d9ff Author: dschuyler <dschuyler@chromium.org> Date: Wed Feb 15 01:14:58 2017 [MD settings] expand subpages to 100% This CL changes a node that was a template prior to CL 266038002, back into being a template. In CL 266038002 I had changed the template to a div, which affects how the CSS is applied (breaking the subpage height). BUG= 690551 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2697453008 Cr-Commit-Position: refs/heads/master@{#450535} [modify] https://crrev.com/0178428f6e9f682eb526fe95b78374448f40d9ff/chrome/browser/resources/settings/basic_page/basic_page.html [modify] https://crrev.com/0178428f6e9f682eb526fe95b78374448f40d9ff/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/0178428f6e9f682eb526fe95b78374448f40d9ff/chrome/test/data/webui/settings/settings_main_test.js
,
Feb 15 2017
,
Feb 17 2017
Issue 689835 has been merged into this issue.
,
Feb 17 2017
Issue 689885 has been merged into this issue. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by scottchen@chromium.org
, Feb 9 2017