Issue 690546 link

Starred by 2 users

Issue metadata

Status:	Archived
Owner:	sky@chromium.org
Closed:	Feb 2017
Cc:	mustash-bugs@google.com
Components:	Internals>Services>WindowService
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	1
Type:	Bug
mustash-1 Proj-Mustash-Mash VerifyIn-59 VerifyIn-60 VerifyIn-61

mash: Dialog boxes have wide/black border

Project Member Reported by jamescook@chromium.org, Feb 9 2017

Issue description

Chrome r449336 on Linux desktop (and device). Happens with Wi-Fi connect dialogs too.

* Navigate to javascript:alert('foo')
* Dialog seems to have window caption area and a black backing area, which makes the border look wrong.

sky, this seems like something we want to fix for Q1. Who would be a good owner?

	bad-dialog-border.png 71.8 KB View Download

Comment 1 by sky@chromium.org, Feb 13 2017

Status: Started (was: Assigned)

Comment 2 by mfomitchev@chromium.org, Feb 14 2017

javascript:alert('foo') doesn't work on my Chromebook at all now. I am synced to refs/heads/master@{#450363}. I think it worked before.. Works on desktop.

Project Member

Comment 3 by bugdroid1@chromium.org, Feb 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f

commit 5c71eb349c1b9f3e0624ad6f27ba0b09c666337f
Author: sky <sky@chromium.org>
Date: Wed Feb 15 19:39:25 2017

mash: wires up shadows for mash

Specifically Widget::InitParams::shadow_type/shadow_elevation weren't
plumbed through for DesktopWindowTreeHostMus. This meant the types
weren't applied at to the aura::Window. They also weren't routed
through the PropertyConverter.

ShadowController is an EnvObserver. ShadowController runs both in mus
and clients. Previously ShadowController keyed off new aura::Window
creation to set the ShadowElevation property. This is problematic for
the mus case as we want mus to make the decisions about shadows
(unless a client has a specific requirement). To get this to work with
mus I added a new shadow elevation type, DEFAULT, which means the
shadow should be chosen based on the window type. ShadowController no
longer sets the shadow type, instead it keys of the existing type and
maps DEFAULT accordingly. This way mash sees DEFAULT and creates the
right shadow.

BUG= 690546   670840 
TEST=none
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2694213003
Cr-Commit-Position: refs/heads/master@{#450775}

[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ash/mus/window_manager.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/chrome/browser/ui/views/frame/immersive_mode_controller_ash.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/components/exo/shell_surface_unittest.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/services/ui/ws/window_manager_state.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/aura/mus/property_converter.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/aura/mus/property_converter.h
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/aura/mus/property_converter_unittest.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/desktop_window_tree_host_mus.h
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/mus/mus_client.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host.h
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/native_widget_aura.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/views/widget/native_widget_aura.h
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow_controller.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow_types.cc
[modify] https://crrev.com/5c71eb349c1b9f3e0624ad6f27ba0b09c666337f/ui/wm/core/shadow_types.h