New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 690536 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Oct 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

WebView L/M bots failing MediaStreamApi test

Project Member Reported by timvolod...@chromium.org, Feb 9 2017

Issue description

started failing here:
https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20L%20%28dbg%29/builds/1982


C   87.113s Main  Detailed Logs
C   87.113s Main  ********************************************************************************
C   87.113s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testMediaStreamApi:
C   87.113s Main  junit.framework.ComparisonFailure: expected:<...allbacks in WebView
C   87.113s Main  [onPermissionRequest: android.webkit.resource.VIDEO_CAPTURE,android.webkit.resource.AUDIO_CAPTURE
C   87.113s Main  request granted: android.webkit.resource.VIDEO_CAPTURE,android.webkit.resource.AUDIO_CAPTURE
C   87.113s Main  PASS: getUserMedia succeeded.
C   87.113s Main  PASS: track.readyState is "live"
C   87.114s Main  PASS: activeStream.active is true]
C   87.114s Main  TEST FINISHED
C   87.114s Main  > but was:<...allbacks in WebView
C   87.114s Main  [FAIL: getUserMedia error callback, reason: DevicesNotFoundError]
C   87.114s Main  TEST FINISHED
C   87.114s Main  >
C   87.114s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.runTest(WebViewLayoutTest.java:297)
C   87.114s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.runWebViewLayoutTest(WebViewLayoutTest.java:270)
C   87.114s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testMediaStreamApi(WebViewLayoutTest.java:243)
C   87.114s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   87.114s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C   87.114s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C   87.114s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
C   87.114s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   87.114s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   87.114s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C   87.115s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
C   87.115s Main  
C   87.115s Main  [FAIL] org.chromium.webview_shell.test.WebViewLayoutTest#testMediaStreamApiDenyPermission:
C   87.115s Main  junit.framework.ComparisonFailure: expected:<...allbacks in WebView
C   87.115s Main  [onPermissionRequest: android.webkit.resource.VIDEO_CAPTURE,android.webkit.resource.AUDIO_CAPTURE
C   87.115s Main  request denied
C   87.115s Main  PASS: getUserMedia error callback, reason: PermissionDenie]dError
C   87.115s Main  TEST FINISHED...> but was:<...allbacks in WebView
C   87.115s Main  [PASS: getUserMedia error callback, reason: DevicesNotFoun]dError
C   87.115s Main  TEST FINISHED...>
C   87.115s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.runTest(WebViewLayoutTest.java:297)
C   87.115s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.runWebViewLayoutTest(WebViewLayoutTest.java:270)
C   87.115s Main  	at org.chromium.webview_shell.test.WebViewLayoutTest.testMediaStreamApiDenyPermission(WebViewLayoutTest.java:236)
C   87.115s Main  	at android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C   87.115s Main  	at android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C   87.115s Main  	at android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C   87.115s Main  	at org.chromium.base.test.BaseTestResult.run(BaseTestResult.java:129)
C   87.115s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   87.116s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   87.116s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:555)
C   87.116s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1853)
C   87.116s Main  ********************************************************************************
C   87.116s Main  Summary
C   87.116s Main  ********************************************************************************
C   87.116s Main  [==========] 22 tests ran.
C   87.116s Main  [  PASSED  ] 19 tests.
C   87.116s Main  [  SKIPPED ] Skipped 1 test, listed below:
C   87.116s Main  [  SKIPPED ] org.chromium.webview_shell.test.WebViewLayoutTest#testEMEPermission
C   87.116s Main  [  FAILED  ] 2 tests, listed below:
C   87.116s Main  [  FAILED  ] org.chromium.webview_shell.test.WebViewLayoutTest#testMediaStreamApi
C   87.117s Main  [  FAILED  ] org.chromium.webview_shell.test.WebViewLayoutTest#testMediaStreamApiDenyPermission
C   87.117s Main  
C   87.117s Main  2 FAILED TESTS
 
Cc: pasko@chromium.org ti...@chromium.org
+cc sheriffs: timav@,pasko@
Cc: guidou@chromium.org
this may be due to https://codereview.chromium.org/2669243004
+guidou@ (as author) : any ideas?
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b1a40f1f43c38f8284a6603511eb3f4e72fb409e

commit b1a40f1f43c38f8284a6603511eb3f4e72fb409e
Author: timvolodine <timvolodine@chromium.org>
Date: Thu Feb 09 18:19:46 2017

[WebViewLayoutTest] Disable two failing media stream api related tests.

Currently failing on the Android WebView L/M bots,
see  crbug.com/690536 .

BUG= 690536 
TBR=timav@chromium.org,pasko@chromium.org

Review-Url: https://codereview.chromium.org/2679423006
Cr-Commit-Position: refs/heads/master@{#449354}

[modify] https://crrev.com/b1a40f1f43c38f8284a6603511eb3f4e72fb409e/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java

Cc: ntfschr@chromium.org
Owner: guidou@chromium.org
Status: Assigned (was: Untriaged)
Assigning to author of the linked CL to answer c#2.
The reason the test is failing is that bots have no media devices and getUserMedia fails without asking for permission in this case.
Before https://codereview.chromium.org/2669243004, getUserMedia always asked for permission, but that was a bug.

The fix is to enable fake devices in the test with the --use-fake-device-for-media-stream command-line flag.

I sent https://chromium-review.googlesource.com/c/chromium/src/+/700259 for review.
I think it should fix it, but I don't know if trybots run this test.
No trybots for these tests. The reviewer should run these manually during review.
Project Member

Comment 8 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/47e7f8304c3b2517aba81688d056ad844bef411b

commit 47e7f8304c3b2517aba81688d056ad844bef411b
Author: Guido Urdaneta <guidou@chromium.org>
Date: Fri Oct 06 13:56:55 2017

Enable Android Web View media permissions tests.

Bug:  690536 
Change-Id: I755b6307ab75733e978d5d67c522a5d7c026d680
Reviewed-on: https://chromium-review.googlesource.com/700259
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507050}
[modify] https://crrev.com/47e7f8304c3b2517aba81688d056ad844bef411b/android_webview/tools/system_webview_shell/layout_tests/src/org/chromium/webview_shell/test/WebViewLayoutTest.java

Status: Fixed (was: Assigned)

Sign in to add a comment